From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmQE9-0003gJ-Tk
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:15:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmQE3-0004In-Uh
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:15:49 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:35688)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmQE3-0004Ie-O8
	for qemu-devel@nongnu.org; Mon, 19 May 2014 12:15:43 -0400
Received: from blackfin.pond.sub.org (p5B32BA71.dip0.t-ipconnect.de
	[91.50.186.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by oxygen.pond.sub.org (Postfix) with ESMTPSA id 4397621394
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 18:15:41 +0200 (CEST)
From: Markus Armbruster <armbru@redhat.com>
References: <1399858555-9672-1-git-send-email-famz@redhat.com>
	<1399858555-9672-3-git-send-email-famz@redhat.com>
	<537A28FF.5040705@redhat.com>
Date: Mon, 19 May 2014 18:15:40 +0200
In-Reply-To: <537A28FF.5040705@redhat.com> (Eric Blake's message of "Mon, 19
	May 2014 09:53:35 -0600")
Message-ID: <8761l1lp77.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>, jcody@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 05/11/2014 07:35 PM, Fam Zheng wrote:
>> This adds the enum of all the operations that can be taken on a block
>> device.
>> 
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> Reviewed-by: Benoit Canet <benoit@irqsave.net>
>> Reviewed-by: Jeff Cody <jcody@redhat.com>
>> ---
>>  include/block/block.h | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>
> Is it worth making this a formal QAPI enum, documented in the .json
> file? If we ever add qapi introspection, it might be nice to know when
> new block op types are added as part of the formal qapi definition.

Moving it into the schema when QAPI needs it shouldn't be hard.