From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCPm-0002Jx-Md for qemu-devel@nongnu.org; Fri, 02 May 2014 08:18:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgCPg-0000Sk-1L for qemu-devel@nongnu.org; Fri, 02 May 2014 08:18:06 -0400 Received: from roura.ac.upc.edu ([147.83.33.10]:41344 helo=roura.ac.upc.es) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgCPf-0000Se-LA for qemu-devel@nongnu.org; Fri, 02 May 2014 08:17:59 -0400 From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= References: <20140430190928.7884.69380.stgit@fimbulvetr.bsc.es> <20140430190946.7884.46553.stgit@fimbulvetr.bsc.es> <5362401A.1030105@redhat.com> Date: Fri, 02 May 2014 14:17:58 +0200 In-Reply-To: <5362401A.1030105@redhat.com> (Eric Blake's message of "Thu, 01 May 2014 06:37:46 -0600") Message-ID: <8761locr2h.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 3/4] qapi: Use an explicit input file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: =?utf-8?Q?Beno=C3=AEt?= Canet , Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino Eric Blake writes: > On 04/30/2014 01:09 PM, Llu=C3=ADs Vilanova wrote: >> Use an explicit input file on the command-line instead of reading from s= tandard >> input. >>=20 >> It also outputs the proper file name when there's an error. >>=20 >> Signed-off-by: Llu=C3=ADs Vilanova >> Reviewed-by: Eric Blake > Technically, you made a non-trivial change (use of perl to sanitize > SRC_PATH) in response to a comment that did not come from my review. You > properly called it out in the cover letter, so I looked at this patch > again; but in general, when making non-trivial changes, it's best to > remove the Reviewed-by to make sure that earlier reviewers notice that > they need to look again, and that they are still happy with the changes. > Fortunately, in this case, your changes still look okay, so I'm okay > with leaving my Reviewed-by on this version of the patch. >> " TEST $*.out") >> @diff -q $(SRC_PATH)/$*.out $*.test.out >> - @diff -q $(SRC_PATH)/$*.err $*.test.err >> + @# Sanitize error messages (make them independent of build directory) >> + @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)/= $*.err - >> @diff -q $(SRC_PATH)/$*.exit $*.test.exit >>=20 Ok. Also note that I did not do the exact change proposed by Markus. I've removed the '^' from the regular expression, since "tracebacks" in error messages also contain the file path. Lluis --=20 "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth