All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Wu <peter@lekensteyn.nl>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: GPF in intel_pmu_lbr_reset() with qemu -cpu host
Date: Fri, 21 Mar 2014 14:48:37 -0700	[thread overview]
Message-ID: <8761n7nryi.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <532CB21B.4040502@zytor.com> (H. Peter Anvin's message of "Fri, 21 Mar 2014 14:41:47 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:
>
> That's why at least to some extent The Right Thing is not to try to
> pretend to be a CPU you don't even know how to emulate.
>
> But again, that has its own issues, too, mostly with userspace
> optimization, and making the Linux code more resilient wouldn't hurt.
> In that sense #GP(0) is *much* better than 0: it unambiguously gives an
> error to work with.

That means we could just throw rdmsr() away and it would be completely
replaced with rdmsr_safe(). But then that will likely cause all kinds
of problems with how to handle these errors and where and how to handle
these exceptions.

I much prefer just to fix KVM. I cannot think of any case
where 0 would cause a major issue.

After all it's virtualization not "rewrite complete kernel for it"

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2014-03-21 21:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 17:42 GPF in intel_pmu_lbr_reset() with qemu -cpu host Peter Wu
2014-03-21 17:46 ` Peter Wu
2014-03-21 19:04   ` Venkatesh Srinivas
2014-03-21 19:09     ` H. Peter Anvin
2014-03-22  7:54       ` Paolo Bonzini
2014-03-22  8:50     ` Gleb Natapov
2014-03-22 10:05       ` Peter Wu
2014-03-22 12:27         ` Gleb Natapov
2014-03-22 21:46           ` H. Peter Anvin
2014-03-22 22:00           ` Peter Wu
2014-03-26  7:23             ` Wu, Feng
2014-03-26  9:38               ` Paolo Bonzini
2014-03-21 19:29 ` Andi Kleen
2014-03-21 20:46   ` H. Peter Anvin
2014-03-21 21:37     ` Andi Kleen
2014-03-21 21:41       ` H. Peter Anvin
2014-03-21 21:48         ` Andi Kleen [this message]
2014-03-21 21:55           ` H. Peter Anvin
2014-03-22  0:22             ` Andi Kleen
2014-03-22  0:26               ` H. Peter Anvin
2014-03-22  0:30                 ` Andi Kleen
2014-03-22  0:34                   ` H. Peter Anvin
2014-03-22 10:01                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761n7nryi.fsf@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peter@lekensteyn.nl \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.