Re: [Qemu-devel] [PATCH v3] char: restore read callback on a reattached (hotplug) chardev

[Markus Armbruster <armbru@redhat.com>]

Gal Hammer <ghammer@redhat.com> writes:

> Fix a bug that was introduced in commit 386a5a1e. A removal of a device
> set the chr handlers to NULL. However when the device is plugged back,
> its read callback is not restored so data can't be transftered from the
> host to the guest (e.g. via the virtio-serial port).
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1027181
>
> Signed-off-by: Gal Hammer <ghammer@redhat.com>
>
> V3: - fix a typo in comment.
>     - move the revision history after the "signed-off-by" tag.

Close, but no cigar :)

It needs to go below the '---' line.

> V2: - do not call chr_update_read_handler on device removal.
>     - add asserts to verify chr_update_read_handler is not called
>       with an assigned fd_in_tag to prevent fd leaks.
>     - update fd and udp backends' chr_update_read_handler function
>       so it won't remove fd_in to prevent a double release.
> ---

Right here is fine.

>  qemu-char.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
[...]