Re: [PATCH] spi: omap-100k: Remove casting the return value which is a void pointer

[Michal Nazarewicz <mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Mon, Dec 09 2013, Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Casting the return value which is a void pointer is redundant.
> The conversion from void pointer to any other pointer type is
> guaranteed by the C programming language.
>
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/spi/spi-omap-100k.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 0d32054..35832a9 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -441,7 +441,7 @@ static int omap1_spi100k_probe(struct platform_device *pdev)
>  	 * You should allocate this with ioremap() before initializing
>  	 * the SPI.
>  	 */
> -	spi100k->base = (void __iomem *)dev_get_platdata(&pdev->dev);
> +	spi100k->base = dev_get_platdata(&pdev->dev);

I might be wrong, but I would assume that __iomem is the important bit
here and removing this cast will make linter unhappy.

>  
>  	spi100k->ick = devm_clk_get(&pdev->dev, "ick");
>  	if (IS_ERR(spi100k->ick)) {
> -- 
> 1.7.10.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]