From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out01.mta.xmission.com ([166.70.13.231]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UgLD5-0005eB-Hy for kexec@lists.infradead.org; Sat, 25 May 2013 20:37:05 +0000 From: ebiederm@xmission.com (Eric W. Biederman) References: <1369400889-11064-1-git-send-email-holzheu@linux.vnet.ibm.com> <20130524143644.GD18218@redhat.com> <20130524170626.2ac06efe@holzheu> <20130524152849.GF18218@redhat.com> <87mwrkatgu.fsf@xmission.com> <51A006CF.90105@gmail.com> <87k3mnahkf.fsf@xmission.com> <51A076FE.3060604@gmail.com> Date: Sat, 25 May 2013 13:36:09 -0700 In-Reply-To: <51A076FE.3060604@gmail.com> (Zhang Yanfei's message of "Sat, 25 May 2013 16:31:58 +0800") Message-ID: <8761y6ajba.fsf@xmission.com> MIME-Version: 1.0 Subject: Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Zhang Yanfei Cc: kexec@lists.infradead.org, Heiko Carstens , Jan Willeke , linux-kernel@vger.kernel.org, HATAYAMA Daisuke , Martin Schwidefsky , Andrew Morton , Michael Holzheu , Vivek Goyal WmhhbmcgWWFuZmVpIDx6aGFuZ3lhbmZlaS55ZXNAZ21haWwuY29tPiB3cml0ZXM6Cgo+IOS6jiAy MDEz5bm0MDXmnIgyNeaXpSAxMTowMSwgRXJpYyBXLiBCaWVkZXJtYW4g5YaZ6YGTOgo+PiBaaGFu ZyBZYW5mZWkgPHpoYW5neWFuZmVpLnllc0BnbWFpbC5jb20+IHdyaXRlczoKPj4gCj4+PiBIZWxs byBFcmljLAo+Pj4KPj4+PiBUaGUgZnVuY3Rpb24gY29weV9vbGRtZW1fcGFnZSBhbHNvIGNvbmNl cm5zIG1lLiAgSSBkb24ndCBoYXZlIGEgY2x1ZSB3aHkKPj4+PiB3ZSBkdXBsaWNhdGUgdGhhdCBm dW5jdGlvbiBvbiBldmVyeSBhcmNoaXRlY3V0cmUgaW4gYSBzbGlnaHRseSBkaWZmZXJlbnQKPj4+ PiBmb3JtLiAgVGhlcmUgc2hvdWxkIGJlIGVub3VnaCBhYnN0cmFjdGlvbnMgaW4gdGhlIGtlcm5l bCB0byBtYWtlIHRoYXQKPj4+PiB1bm5lY2Vzc2FyeS4gIEkgd291bGQgYmUgZ2xhZCB0byBzZWUg dGhhdCBmdW5jdGlvbiBnbywgYW5kIHJlbW92ZSB0aGUKPj4+PiBwb3NzaWJpbGl0eSBvZiBjb25m dXNpb24gdGhhdCBoYXBwZW5lZCBvbiBzMzkwLgo+Pj4KPj4+IFlvdSBtZWFuIHdlIHNob3VsZCBo YXZlIGEgY29tbW9uIGNvcHlfb2xkbWVtX3BhZ2UgZm9yIGFsbCBhcmNoaXRlY3R1cmVzPyBBbmQK Pj4+IGp1c3QgbGlrZSB2aXZlayBzYWlkIGFib3ZlLCBmb3IgczM5MCwgd2Ugc2hvdWxkIHB1dCB0 aGUgc3dhcCBpbmZvIGluIHRoZSBlbGYKPj4+IGhlYWRlcnMgaW5zdGVhZCBvZiBkb2luZyB0aGF0 IGluIGNvcHlfb2xkbWVtX3BhZ2UuCj4+IAo+PiBFeGFjdGx5Lgo+PiAKPj4gVGhlIHVzZXIgc3Bh Y2UgY2hhbmdlIGluIC9zYmluL2tleGVjIHNob3VsZCBldmVuIGJlIGJhY2t3YXJkcyBjb21wYXRp YmxlCj4+IGZvciBzMzkwLiAgU28gZml4aW5nIC9zYmluL2tleGVjIHNob3VsZCBwcm9iYWJseSBj b21lIGZpcnN0Lgo+PiAKPgo+IEkgYW0ga2luZCBvZiBub3Qgc3VyZSBhYm91dCB0aGUgImJhY2t3 YXJkcyBjb21wYXRpYmxlIGZvciBzMzkwIiB5b3UgbWVhbnQuCj4KPiBGb3IgczM5MCwgaWYgd2Ug cHV0IHN3YXAgaW5mbyBpbnRvIHRoZSBlbGYgaGVhZGVyLCBUaGlzIHdpbGwgY2hhbmdlIC9zYmlu L2tleGVjLgo+IEJ1dCBhdCB0aGlzIHBvaW50LCBjb3B5X29sZG1lbV9wYWdlIGlzIHN0aWxsIGRv aW5nIHRoZSBzd2FwIHdoZW4gd2UgdHJ5IHRvIHJlYWQKPiB0aGUgcGFnZXMgYW1vbmcgWzAgLSBP TERNRU1fU0laRV0gYW5kIFtPTERNRU1fQkFTRSAtIE9MRE1FTV9CQVNFICsgT0xETUVNX1NJWkVd Lgo+IFNvIHJlbW92aW5nIHRoZSBzd2FwIGluIGNvcHlfb2xkbWVtX3BhZ2Ugc2hvdWxkIGJlIGRv bmUgYXQgdGhlIHNhbWUgdGltZS4KPiBOZXcga2V4ZWMgd2l0aCBvbGQga2VybmVscyB3b3VsZCBm YWlsIGFuZCBvbGQga2V4ZWMgd2l0aCBuZXcga2VybmVscyB3b3VsZCBmYWlsIHRvby4KPgo+IFNv IGNvdWxkIHlvdSBwbGVhc2UgZXhwbGFpbiBtb3JlIGFib3V0IHRoZSAiImJhY2t3YXJkcyBjb21w YXRpYmxlIi4gQW5kIHBsZWFzZQo+IGNvcnJlY3QgbWUgaWYgSSBhbSB3cm9uZy4KCkl0IGxvb2tz IGxpa2UgbXkgbWlzcmVhZGluZyBvZiB0aGluZ3MuICBJIHdhcyBub3QgZXhwZWN0aW5nIHRoZSBl eGlzdGluZwpjb3B5X29sZG1lbV9wYWdlIHRvIGRvIGEgY29tcGxldGUgc3dhcCBvZiBhZGRyZXNz ZXMuICBJIHdhcyBleHBlY3RpbmcKc29tZXRoaW5nIGxpa2UgdGhlIHJlc3VsdCBvYnRhaW5lZCBi eSBkb2luZyBhIGhlYWRlciBzd2FwIHdpdGggdGhlIEVMRgpoZWFkZXJzIHdoZXJlIHBhcnQgb2Yg dGhlIGFkZHJlc3Mgd2FzIHRyYW5zbGF0ZWQgYW5kIHRoZSByZXN0IHdhcyBzaW1wbHkKbm90IG1l bnRpb25lZC4KCkJ1dCBmcm9tIG90aGVyIHJlcGxpZXMgaXQgYXBwZWFycyB0aGVyZSBpc24ndCBh IHByb2JsZW0uCgpFcmljCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18Ka2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758050Ab3EYUgd (ORCPT ); Sat, 25 May 2013 16:36:33 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:34297 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757947Ab3EYUgb convert rfc822-to-8bit (ORCPT ); Sat, 25 May 2013 16:36:31 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Zhang Yanfei Cc: Vivek Goyal , Michael Holzheu , HATAYAMA Daisuke , Jan Willeke , Martin Schwidefsky , Heiko Carstens , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Andrew Morton References: <1369400889-11064-1-git-send-email-holzheu@linux.vnet.ibm.com> <20130524143644.GD18218@redhat.com> <20130524170626.2ac06efe@holzheu> <20130524152849.GF18218@redhat.com> <87mwrkatgu.fsf@xmission.com> <51A006CF.90105@gmail.com> <87k3mnahkf.fsf@xmission.com> <51A076FE.3060604@gmail.com> Date: Sat, 25 May 2013 13:36:09 -0700 In-Reply-To: <51A076FE.3060604@gmail.com> (Zhang Yanfei's message of "Sat, 25 May 2013 16:31:58 +0800") Message-ID: <8761y6ajba.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-AID: U2FsdGVkX19MWJ7MIN2aOHBpWntggRtT91YD7Nbk/Ss= X-SA-Exim-Connect-IP: 98.207.154.105 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Zhang Yanfei X-Spam-Relay-Country: Subject: Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390 X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 14 Nov 2012 14:26:46 -0700) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Zhang Yanfei writes: > 于 2013年05月25日 11:01, Eric W. Biederman 写道: >> Zhang Yanfei writes: >> >>> Hello Eric, >>> >>>> The function copy_oldmem_page also concerns me. I don't have a clue why >>>> we duplicate that function on every architecutre in a slightly different >>>> form. There should be enough abstractions in the kernel to make that >>>> unnecessary. I would be glad to see that function go, and remove the >>>> possibility of confusion that happened on s390. >>> >>> You mean we should have a common copy_oldmem_page for all architectures? And >>> just like vivek said above, for s390, we should put the swap info in the elf >>> headers instead of doing that in copy_oldmem_page. >> >> Exactly. >> >> The user space change in /sbin/kexec should even be backwards compatible >> for s390. So fixing /sbin/kexec should probably come first. >> > > I am kind of not sure about the "backwards compatible for s390" you meant. > > For s390, if we put swap info into the elf header, This will change /sbin/kexec. > But at this point, copy_oldmem_page is still doing the swap when we try to read > the pages among [0 - OLDMEM_SIZE] and [OLDMEM_BASE - OLDMEM_BASE + OLDMEM_SIZE]. > So removing the swap in copy_oldmem_page should be done at the same time. > New kexec with old kernels would fail and old kexec with new kernels would fail too. > > So could you please explain more about the ""backwards compatible". And please > correct me if I am wrong. It looks like my misreading of things. I was not expecting the existing copy_oldmem_page to do a complete swap of addresses. I was expecting something like the result obtained by doing a header swap with the ELF headers where part of the address was translated and the rest was simply not mentioned. But from other replies it appears there isn't a problem. Eric