From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWwIL-0007Bc-UB for qemu-devel@nongnu.org; Mon, 29 Apr 2013 18:11:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWwIH-0000dy-0f for qemu-devel@nongnu.org; Mon, 29 Apr 2013 18:11:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWwIG-0000dU-Oa for qemu-devel@nongnu.org; Mon, 29 Apr 2013 18:11:32 -0400 From: Juan Quintela In-Reply-To: <517EDEE7.8070309@redhat.com> (Paolo Bonzini's message of "Mon, 29 Apr 2013 22:58:15 +0200") References: <1367258703-6930-1-git-send-email-aliguori@us.ibm.com> <517EDEE7.8070309@redhat.com> Date: Tue, 30 Apr 2013 00:10:21 +0200 Message-ID: <8761z5ng36.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Anthony Liguori , Guan Xuetao , Christophe Lyon , Max Filippov , Richard Sandiford , Jocelyn Mayer , qemu-devel@nongnu.org, Avi Kivity , Blue Swirl , Stefan Weil , malc , Paul Brook , Thiemo Seufer , Andreas =?utf-8?Q?F=C3=A4rber?= , Aurelien Jarno , Richard Henderson Paolo Bonzini wrote: > Il 29/04/2013 20:05, Anthony Liguori ha scritto: >> N.B. If you are on CC, see after the '---' for a requested action! >>=20 >> The license of SoftFloat-2b is claimed to be GPLv2 incompatible by >> the FSF due to an indemnification clause. The previous release, >> SoftFloat-2a, did not contain this clause. The only changes between >> these two versions as far as QEMU is concerned is the license change >> and a global modification of the comment structure. This patch rebases >> our softfloat code to SoftFloat-2a in order to have a GPLv2 compatible >> license. >>=20 >> Please note, this is a comment-only change. The resulting binary should >> be the same. >>=20 >> I created this patch using the following strategy: >>=20 >> 1) Create a branch using the original import of softfloat code: >> $ git checkout 158142c2c2df728cfa3b5320c65534921a764f26 >>=20 >> 2) Remove carriage returns from Softfloat-2b >>=20 >> 3) Compare each of the softfloat files against Softfloat-2b using the >> following mapping to generate Fabrice's original softfloat changes: >>=20 >> - fpu/softfloat.c -> softfloat/bits64/softfloat.c >> - fpu/softfloat.h -> softfloat/bits64/386-Win32-gcc/softfloat.h >> - fpu/softfloat-macros.h -> softfloat/bits64/softfloat-macros >> - fpu/softfloat-specialize.h -> > softfloat/bits64/386-Win32-gcc/softfloat-specialize >>=20 >> 4) Replace our softfloat files with the corresponding files from Softflo= at-2a >>=20 >> 5) Apply the diffs from (3) to (4) and commit >>=20 >> 6) Create a diff between (5) and 158142c2c2df728cfa3b5320c65534921a764f26 >> - This diff consists 100% of licensing change + comment reformating >>=20 >> 7) Checkout the latest master branch, apply the diff from (6) >> - There were a lot of comment rejects, confirmed this was only commen= ts >> and then used an emacs macro to rewrite the comments to the Softflo= at-2a >> form. >>=20 >> Cc: Andreas F=C3=A4rber >> Cc: Aurelien Jarno >> Cc: Avi Kivity >> Cc: Ben Taylor >> Cc: Blue Swirl >> Cc: Christophe Lyon >> Cc: Fabrice Bellard >> Cc: Guan Xuetao >> Cc: Jocelyn Mayer >> Cc: Juan Quintela >> Cc: malc >> Cc: Max Filippov >> Cc: Paolo Bonzini >> Cc: Paul Brook >> Cc: Peter Maydell >> Cc: Richard Henderson >> Cc: Richard Sandiford >> Cc: Stefan Weil >> Cc: Thiemo Seufer >> Signed-off-by: Anthony Liguori >> --- >> In order to make this change, we need to relicense all contributions >> from initial import of the SoftFloat code to match the license of >> SoftFloat-2a (instead of the implied SoftFloat-2b license). > > All Red Hat contributions (at least Avi, Juan, me; don't know about rth) > are available under GPLv2+; also other authors agreed on it. For this > particular license, > > Acked-by: Paolo Bonzini Acked-by: Juan Quintela As said by paolo, any contribution by me is under GPLv2+ O:-) Anthony, thanks for the effort. Later, Juan.