From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH V2 11/22] virtio-scsi: use virtqueue_add_sgs for command buffers Date: Wed, 20 Mar 2013 11:05:50 +1030 Message-ID: <87620mrjq1.fsf@rustcorp.com.au> References: <20130319065131.GA31573@hj.localdomain> <1363686539-13326-1-git-send-email-gaowanlong@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1363686539-13326-1-git-send-email-gaowanlong@cn.fujitsu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Wanlong Gao , asias@redhat.com Cc: pbonzini@redhat.com, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org Wanlong Gao writes: > Using the new virtqueue_add_sgs function lets us simplify the queueing > path. In particular, all data protected by the tgt_lock is just gone > (multiqueue will find a new use for the lock). > > Signed-off-by: Wanlong Gao > Acked-by: Paolo Bonzini > Reviewed-by: Asias He > Signed-off-by: Rusty Russell Thanks... and I agree with Paulo: this is nice. I've replaced the patch I posted with this one. Cheers, Rusty.