From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF8Na-0006oG-4Z for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:27:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF8NW-0002rq-19 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:27:26 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:56459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF8NV-0002qy-G9 for qemu-devel@nongnu.org; Mon, 11 Mar 2013 15:27:21 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 Mar 2013 05:22:12 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 0771F2CE804D for ; Tue, 12 Mar 2013 06:27:07 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2BJEEoc7209312 for ; Tue, 12 Mar 2013 06:14:15 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2BJR5f8017994 for ; Tue, 12 Mar 2013 06:27:05 +1100 From: Anthony Liguori In-Reply-To: <20130311173929.GA29465@redhat.com> References: <20130307184647.GA31012@redhat.com> <87d2vbx9rz.fsf@blackfin.pond.sub.org> <20130307202309.GA13088@redhat.com> <87a9qel3v0.fsf@blackfin.pond.sub.org> <87vc92dndv.fsf@codemonkey.ws> <20130311173929.GA29465@redhat.com> Date: Mon, 11 Mar 2013 14:26:58 -0500 Message-ID: <87620xrb3x.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v4] qdev: DEVICE_DELETED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , Gerd Hoffmann , Paolo Bonzini , Luiz Capitulino , Andreas =?utf-8?Q?F=C3=A4rber?= "Michael S. Tsirkin" writes: > On Fri, Mar 08, 2013 at 07:36:28AM -0600, Anthony Liguori wrote: >> Markus Armbruster writes: >> >> > "Michael S. Tsirkin" writes: >> > >> >> On Thu, Mar 07, 2013 at 08:57:52PM +0100, Markus Armbruster wrote: >> >>> "Michael S. Tsirkin" writes: >> >>> >> >>> > libvirt has a long-standing bug: when removing the device, >> >>> > it can request removal but does not know when the >> >>> > removal completes. Add an event so we can fix this in a robust way. >> >>> > >> >>> > Signed-off-by: Michael S. Tsirkin >> >>> >> >>> Speaking as the acting QMP maintainer, just to avoid misunderstandings: >> >>> there's disagreement on the event's design, namely when it should fire, >> >>> and how it should name the device. I don't want the discussion >> >>> preempted by a commit. >> >> >> >> Yes, you are asking for more functionality, but can I add this in a >> >> follow-up commit please? I prefer this patch as is, as it can be >> >> backported to stable branches and downstreams. Upstream a follow up >> >> patch can add fields and more triggers which won't apply to any >> >> downstreams. >> > >> > If you want to address my review comments in a separate patch, go right >> > ahead. Please post both together as a series, for coherent review and >> > to simplify patch tracking. >> > >> > I'm asking for two things: >> > >> > 1. Event member path. Fair to call this "more functionality". I agree >> > that backporting it to pre-QOM versions isn't practical. >> > >> > 2. Sane event trigger condition: on any device deletion, not just when >> > the device happens to have a qdev ID. This isn't "more", it's >> > "different". >> >> Ack. >> >> Regards, >> >> Anthony Liguori > > > So how does one get the path that you require? > > ERROR:qom/object.c:1011:object_get_canonical_path: assertion failed: > (prop != NULL) Can you share your patch? This means something is wrong. All devices have a canonical path. Regards, Anthony Liguori