All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Virtualization List <virtualization@lists.linux-foundation.org>
Cc: Amit Shah <amit.shah@redhat.com>
Subject: Re: [PATCH 1/1] virtio: rng: disallow multiple device registrations, fixes crashes
Date: Thu, 07 Mar 2013 12:06:31 +1100	[thread overview]
Message-ID: <8762149fxk.fsf@rustcorp.com.au> (raw)
In-Reply-To: <58c84c464bca72f80fec188f0ae0269058c6cf03.1362557573.git.amit.shah@redhat.com>

Amit Shah <amit.shah@redhat.com> writes:
> The code currently only supports one virtio-rng device at a time.
> Invoking guests with multiple devices causes the guest to blow up.
>
> Check if we've already registered and initialised the driver.  Also
> cleanup in case of registration errors or hot-unplug so that a new
> device can be used.
>
> Reported-by: Peter Krempa <pkrempa@redhat.com>
> Reported-by: <yunzheng@redhat.com>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>
> Also valid for stable?

Yes.  We could fix virtio-rng to allow multiple rngs, but of course it
will fail anyway since hwrng wants unique names.  And changing the name
to be virtio-%u will probably break things, for no real upside.

Applied, and Cc:stable added.

Thanks,
Rusty.

  reply	other threads:[~2013-03-07  1:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  8:13 [PATCH 1/1] virtio: rng: disallow multiple device registrations, fixes crashes Amit Shah
2013-03-07  1:06 ` Rusty Russell [this message]
2013-03-07  8:23   ` Amit Shah
2013-03-07  8:23     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762149fxk.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=amit.shah@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.