From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Stecklina Subject: Re: KVM VMX: register state after reset violates spec Date: Mon, 03 Dec 2012 14:49:59 +0100 Message-ID: <87624jp7nc.fsf@os.inf.tu-dresden.de> References: <87y5hkjydx.fsf@os.inf.tu-dresden.de> <20121202133802.GA8731@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from os.inf.tu-dresden.de ([141.76.48.99]:39805 "EHLO os.inf.tu-dresden.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028Ab2LCNuA (ORCPT ); Mon, 3 Dec 2012 08:50:00 -0500 In-Reply-To: <20121202133802.GA8731@redhat.com> (Gleb Natapov's message of "Sun, 2 Dec 2012 15:38:02 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Thus spake Gleb Natapov : > It should, so why not move the fix to kvm_vcpu_reset() so it will work > for both. Also what about R8-R15? Intel SDM says nothing about them in > the section you mention, but in Volume 1 section 3.4.1.1 is says: [...] > I take it that they are undefined on the first transition to 64-bit mode > too. AMD spec says that they should be zeroed on reset, so lets do that. > Also SVM does not set EDX to correct value on reset. It should be: I have posted a new version of the patch taking your suggestions into account. The VMX version is working for me. I could not test it on AMD hardware, though. Julian