All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Allocate seqno conditionally in i915_add_request
Date: Thu, 22 Nov 2012 13:59:13 +0200	[thread overview]
Message-ID: <87624xluge.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <275ffc$7h3g4p@fmsmga002.fm.intel.com>

On Thu, 22 Nov 2012 11:13:04 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Thu, 22 Nov 2012 12:51:29 +0200, Mika Kuoppala <mika.kuoppala@intel.com> wrote:
> > If seqno already exists, add request with that seqno. Otherwise
> > allocate new seqno for this request. Make i915_gem_check_olr use
> > already allocated seqnos in order to avoid nesting into
> > i915_gem_alloc_seqno during i915_gem_idle().
> 
> I really don't like that mess in i915_add_request(). I was thinking more
> alongthe lines of:
> 
> http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=bug55984&id=87cf35086182f9ce36bb8d85a0fe4cfc136cb3e2
> -Chris

Yours look much better. I got distracted by intel_ring_begin can't fail
in do_execbuffer.

With quick testing this also can survive hundreds of wraps.

Please send yours for review.

Thanks,
-Mika

> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2012-11-22 11:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22 10:51 [PATCH 0/5] Wrap handling / seqno allocations Mika Kuoppala
2012-11-22 10:51 ` [PATCH 1/5] drm/i915: Wait upon the last request seqno, rather than a future seqno Mika Kuoppala
2012-11-22 10:51 ` [PATCH 2/5] drm/i915: fix debugfs seqno info print to use uint Mika Kuoppala
2012-11-22 10:51 ` [PATCH 3/5] drm/i915: Add i915_gem_alloc_seqno Mika Kuoppala
2012-11-22 10:51 ` [PATCH 4/5] drm/i915: Allocate seqno conditionally in i915_add_request Mika Kuoppala
2012-11-22 11:13   ` Chris Wilson
2012-11-22 11:59     ` Mika Kuoppala [this message]
2012-11-22 10:51 ` [PATCH 5/5] drm/i915: don't return seqno from ring->add_request() Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87624xluge.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.