All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: The bug of iput() removal from flusher thread?
Date: Sat, 17 Nov 2012 17:42:30 +0900	[thread overview]
Message-ID: <8762541uyx.fsf@devron.myhome.or.jp> (raw)

Hi,

In 169ebd90131b2ffca74bb2dbe7eeacd39fb83714 commit, writeback doesn't
__iget()/iput() anymore.

This means nobody moves the inode to lru list. I.e.

	new_inode()
	dirty_inode()
	iput_final()
		/* keep inode without adding lru */
	flush indoes
        /* clean inode is not on lru */

I noticed this situation in my FS though, I think the same bug is on all
FSes of linus tree too, after this commit.

Am I missing the something?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

             reply	other threads:[~2012-11-17  8:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17  8:42 OGAWA Hirofumi [this message]
2012-11-19  8:56 ` The bug of iput() removal from flusher thread? OGAWA Hirofumi
2012-11-19 14:51   ` Jan Kara
2012-11-19 19:41     ` Jan Kara
2012-11-19 20:51       ` OGAWA Hirofumi
2012-11-19 21:24         ` Jan Kara
2012-11-19 21:53           ` OGAWA Hirofumi
2012-11-21  1:11             ` Jan Kara
2012-11-21  1:48               ` Jan Kara
2012-11-21  2:44                 ` Dave Chinner
2012-11-21 17:08                   ` Jan Kara
2012-11-21  8:05                 ` Andrew Morton
2012-11-21  8:22                   ` Dave Chinner
2012-11-20 22:37       ` Dave Chinner
2012-11-21  1:30         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762541uyx.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.