All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] schifra: new package
Date: Mon, 10 Sep 2012 10:45:10 +0200	[thread overview]
Message-ID: <87627m1d2h.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1345801194-28735-1-git-send-email-spdawson@gmail.com> (spdawson@gmail.com's message of "Fri, 24 Aug 2012 10:39:54 +0100")

>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

 spdawson> From: Simon Dawson <spdawson@gmail.com>
 spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>

Committed with minor changes (see below), thanks.

 spdawson> +#############################################################
 spdawson> +#
 spdawson> +# schifra
 spdawson> +#
 spdawson> +#############################################################
 spdawson> +SCHIFRA_VERSION = 0.0.1
 spdawson> +SCHIFRA_SITE = http://www.schifra.com/downloads
 spdawson> +SCHIFRA_SOURCE = schifra.tgz
 spdawson> +SCHIFRA_INSTALL_STAGING = YES
 spdawson> +SCHIFRA_LICENSE = schifra license
 spdawson> +SCHIFRA_LICENSE_FILES = schifra_license.txt
 spdawson> +
 spdawson> +SCHIFRA_MAKE_OPT = COMPILER="$(TARGET_CXX)"

We also need to pass TARGET_CFLAGS / TARGET_LDFLAGS

 spdawson> +
 spdawson> +# The examples are the only buildable artefacts.
 spdawson> +ifeq ($(BR2_PACKAGE_SCHIFRA_EXAMPLES),y)
 spdawson> +define SCHIFRA_BUILD_CMDS
 spdawson> +	$(MAKE) -C $(@D) $(SCHIFRA_MAKE_OPT) all
 spdawson> +endef
 spdawson> +endif
 spdawson> +
 spdawson> +define SCHIFRA_INSTALL_TARGET_CMDS
 spdawson> +	$(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/include
 spdawson> +	$(INSTALL) -m 0644 -t $(TARGET_DIR)/usr/include $(@D)/schifra_*.hpp
 spdawson> +	$(INSTALL) -m 0755 -d $(TARGET_DIR)/usr/bin
 spdawson> +	for i in `find $(@D) -type f -name 'schifra_*' -executable` ; \
 spdawson> +	do \
 spdawson> +		$(INSTALL) -m 0755 -t $(TARGET_DIR)/usr/bin $$i ; \
 spdawson> +	done

I would like to keep the examples handling seperate (similar to the
build step), so I moved it to a _TARGET_INSTALL hook.

 spdawson> +endef
 spdawson> +
 spdawson> +define SCHIFRA_INSTALL_STAGING_CMDS
 spdawson> +	$(INSTALL) -m 0755 -d $(STAGING_DIR)/usr/include
 spdawson> +	$(INSTALL) -m 0644 -t $(STAGING_DIR)/usr/include $(@D)/schifra_*.hpp

We typically do a loop doing install -D instead, so I changed it to that
for consistency.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2012-09-10  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  9:39 [Buildroot] [PATCH] schifra: new package spdawson at gmail.com
2012-08-25 15:21 ` Thomas Petazzoni
2012-08-27 10:52   ` Luca Ceresoli
2012-08-27 22:22     ` Arnout Vandecappelle
2012-08-28  7:34       ` Simon Dawson
2012-09-10  8:45 ` Peter Korsgaard [this message]
2012-09-10  9:16   ` Simon Dawson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87627m1d2h.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.