From: ebiederm@xmission.com (Eric W. Biederman)
To: kernel-janitors@vger.kernel.org
Subject: Re: [userns:userns-always-map-user-v52 38/154] fs/quota/quota.c:246: undefined reference to `qid_val
Date: Sun, 02 Sep 2012 03:18:07 +0000 [thread overview]
Message-ID: <87627x864w.fsf@xmission.com> (raw)
In-Reply-To: <20120902022057.GA14240@localhost>
Fengguang Wu <fengguang.wu@intel.com> writes:
> On Sat, Sep 01, 2012 at 07:36:10PM -0700, Eric W. Biederman wrote:
>> Fengguang Wu <fengguang.wu@intel.com> writes:
>>
>> > Hi Eric,
>> >
>> > FYI, kernel build failed on
>>
>> Thanks.
>>
>> It looks like I misread the kconfig dependencies.
>>
>> kqid. should have depended on QUOTACTL not QUOTA. Sigh.
>
> OK. This commit also triggers another error:
>
> N: make[3]: *** No rule to make target `fs/quota/kqid.o', needed by
> `fs/quota/built-in.o'.
Yeah. I forgot to git add fs/quota/kqid.c
It looks like I was a bit too tired when I pushed up this change.
Again, thanks for catching this.
Eric
prev parent reply other threads:[~2012-09-02 3:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 2:20 [userns:userns-always-map-user-v52 38/154] fs/quota/quota.c:246: undefined reference to `qid_valid' Fengguang Wu
2012-09-02 2:36 ` [userns:userns-always-map-user-v52 38/154] fs/quota/quota.c:246: undefined reference to `qid_val Eric W. Biederman
2012-09-02 2:49 ` Fengguang Wu
2012-09-02 3:18 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87627x864w.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.