From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szl70-0001mU-MV for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:02:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Szl6v-0007sV-JP for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:02:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szl6v-0007sR-BO for qemu-devel@nongnu.org; Fri, 10 Aug 2012 05:02:25 -0400 From: Markus Armbruster References: <1344354826-10375-1-git-send-email-lcapitulino@redhat.com> <1344354826-10375-14-git-send-email-lcapitulino@redhat.com> Date: Fri, 10 Aug 2012 11:02:21 +0200 In-Reply-To: <1344354826-10375-14-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Tue, 7 Aug 2012 12:53:24 -0300") Message-ID: <87628rce76.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com Luiz Capitulino writes: > It's not needed. The device name is already known and > monitor_read_block_device_key() knows how to do the rest. This overly > simplifies hmp_change(). "overly"? My usual complaint about commit messages is that they fail to explain the change's purpose. Yours explains your reason just fine, but the description of what's done falls a bit short. I'd like to see something like "replace duplicated password prompting code by common monitor_read_block_device_key()".