From: "Štěpán Němec" <stepnem@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: J Smith <dark.panda@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] grep: add a grep.patternType configuration setting
Date: Thu, 02 Aug 2012 00:19:15 +0200 [thread overview]
Message-ID: <876292ntlo.fsf@gmail.com> (raw)
In-Reply-To: <7vpq7ae0pj.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 01 Aug 2012 14:55:52 -0700")
On Wed, 01 Aug 2012 14:55:52 -0700
Junio C. Hamano wrote:
> J Smith <dark.panda@gmail.com> writes:
>
>> grep.extendedRegexp::
>> - If set to true, enable '--extended-regexp' option by default.
>> + If set to true, enable '--extended-regexp' option by default. This
>> + option is ignored when the 'grep.patternType' option is set.
>
> We are not going to make grep.patternType a boolean, so "when ... is
> set" is fine, but if we were to allow grep.patternType to be set to
> "false", the description gives ambiguity to some readers who do.
> Perhaps s/is set/is given/ is safer.
I'm not a native speaker, but to me "is given" implies command line (the
meaning is clear here, it just sounds a bit weird). If it's not just me,
"is used" or "has a value" might be better.
--
Štěpán
next prev parent reply other threads:[~2012-08-01 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:29 [PATCH/RFC] grep: add a grep.patternType configuration setting J Smith
2012-08-01 21:55 ` Junio C Hamano
2012-08-01 22:19 ` Štěpán Němec [this message]
2012-08-01 22:49 ` J Smith
2012-08-02 14:47 ` J Smith
-- strict thread matches above, loose matches on Subject: below --
2012-08-03 14:53 J Smith
2012-08-03 16:39 ` Junio C Hamano
2012-08-03 18:22 ` J Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876292ntlo.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=dark.panda@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.