From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1SA1JE-0002F9-4L
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:49:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1SA1J8-0007K4-W4
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:49:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1SA1J8-0007Jq-O9
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:49:10 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4F68A52F.3070003@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?=
	=?utf-8?Q?'s?= message of "Tue, 20 Mar 2012 16:41:35 +0100")
References: <1332257065-31184-1-git-send-email-quintela@redhat.com>
	<4F68A52F.3070003@suse.de>
Date: Tue, 20 Mar 2012 16:49:06 +0100
Message-ID: <8762dzuvbh.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES
	compile
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> Am 20.03.2012 16:24, schrieb Juan Quintela:
>> This change makes it compile and return the same value than the #undef o=
ne.
>>=20
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Cool,
>
> Acked-by: Andreas F=C3=A4rber <afaerber@suse.de>
>
> Tested the default, non-struct version only.
>
> Juan, would it make sense to add a configure option for this #define,
> similar to --enable-debug-tcg?

It depends of its users, clearly it was not used for quite long.  Put in
under --enabled-debug?  Notice that I have only used this _once_, so I
am not the best person to decide.

Later, Juan.