All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 14/14] libedbus: Add new package
Date: Sun, 29 Jan 2012 23:22:45 +0100	[thread overview]
Message-ID: <8762fui1xm.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAFbHwiTEaezGnZBkvvfH_gMODERa=FAhXZqyjZ80bf02YF4+iw@mail.gmail.com> (Will Newton's message of "Thu, 26 Jan 2012 17:42:59 +0000")

>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:

 Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
 Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed with minor tweaks, thanks.

 Will> new file mode 100644
 Will> index 0000000..27993f0
 Will> --- /dev/null
 Will> +++ b/package/efl/libedbus/Config.in
 Will> @@ -0,0 +1,10 @@
 Will> +config BR2_PACKAGE_LIBEDBUS
 Will> +	bool "libedbus"
 Will> +	select BR2_PACKAGE_LIBEINA
 Will> +	select BR2_PACKAGE_LIBECORE
 Will> +	select BR2_PACKAGE_DBUS
 Will> +	select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_LIBXML2

I prefer to just do depends on BR2_PACKAGE_DBUS (atleast until Arnout's
patches are merged).

 Will> +	help
 Will> +	  E_Dbus is a set of wrappers around D-Bus APIs so they can be
 Will> +	  easily used by EFL applications, automatically providing
 Will> +	  Ecore/main loop integration, as well as Eina data types.

You forgot upstream URL.

 Will> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
 Will> new file mode 100644
 Will> index 0000000..fe883e0
 Will> --- /dev/null
 Will> +++ b/package/efl/libedbus/libedbus.mk
 Will> @@ -0,0 +1,15 @@
 Will> +#############################################################
 Will> +#
 Will> +# libedbus
 Will> +#
 Will> +#############################################################
 Will> +
 Will> +LIBEDBUS_VERSION = 1.1.0
 Will> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
 Will> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
 Will> +LIBEDBUS_AUTORECONF = YES

You are not patching any autotools files, so no need for AUTORECONF.


-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-01-29 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-29 22:22 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-23 16:36 Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32   ` Will Newton
2012-01-26 23:40     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762fui1xm.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.