All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] New package: linux-firmware
Date: Thu, 26 Jan 2012 13:43:03 +0100	[thread overview]
Message-ID: <8762fy4otk.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <ad47d31d76e74e891bacdf8b9470a643@zacarias.com.ar> (Gustavo Zacarias's message of "Thu, 26 Jan 2012 09:00:47 -0300")

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

Hi,

 Gustavo> These constructs can get too long too fast, why not something
 Gustavo> like...

 Gustavo> ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RALINK_RT2XXX),y)
 Gustavo>     LINUX_FIRMWARE_FILES += rt2860.bin rt2870.bin rt30*.bin
 Gustavo> LICENCE.ralink-firmware.txt
 Gustavo> endif

 Gustavo> define LINUX_FIRMWARE_INSTALL_TARGET_CMDS
 Gustavo>     cp -af $(addprefix $(@D)/, $(LINUX_FIRMWARE_FILES))
 Gustavo> $(TARGET_DIR)/lib/firmware
 Gustavo> endef

Agreed, except you should use a loop and install -D, so subdirs are
supported.

E.G.

        for i in $(LINUX_FIRMWARE_FILES); do \
          $i(INSTALL) -m 0644 -D $(@D)/$$i $(TARGET_DIR)/lib/firmware/$$i; \
        done

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2012-01-26 12:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26 11:30 [Buildroot] [PATCH v3] New package: linux-firmware yegorslists at googlemail.com
2012-01-26 12:00 ` Gustavo Zacarias
2012-01-26 12:16   ` Thomas Petazzoni
2012-01-26 12:43   ` Peter Korsgaard [this message]
2012-01-26 12:47     ` Gustavo Zacarias
2012-01-26 12:57       ` Peter Korsgaard
2012-01-26 12:59         ` Gustavo Zacarias
2012-01-26 13:44       ` Yegor Yefremov
2012-01-26 13:53         ` Peter Korsgaard
2012-01-26 13:55         ` Gustavo Zacarias
2012-01-26 14:19           ` Yegor Yefremov
2012-01-26 14:45             ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762fy4otk.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.