All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Takashi Iwai <tiwai@suse.de>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Pawel Moll <pawel.moll@arm.com>, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 13/15] module_param: make bool parameters really bool (sound)
Date: Mon, 19 Dec 2011 12:25:40 +1030	[thread overview]
Message-ID: <8762hdpboj.fsf@rustcorp.com.au> (raw)
In-Reply-To: <s5hiplim2tt.wl%tiwai@suse.de>

On Thu, 15 Dec 2011 13:33:50 +0100, Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 15 Dec 2011 13:49:36 +1030,
> Rusty Russell wrote:
> > 
> > module_param(bool) used to counter-intuitively take an int.  In
> > fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
> > trick.
> > 
> > It's time to remove the int/unsigned int option.  For this version
> > it'll simply give a warning, but it'll break next kernel version.
> > 
> > Cc: Jaroslav Kysela <perex@perex.cz>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: alsa-devel@alsa-project.org
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> 
> Acked-by: Takashi Iwai <tiwai@suse.de>
> 
> (Maybe it'd be good to change with true and false instead of 1 and 0,
>  too.  But it's subtle things and we don't have to mix up in a single
>  patch.)
> 
> Rusty, would you like to merge from your tree, or shall I merge
> through sound tree?

Please take it :)

I'll take the bint one, since that's got other dependencies, but this
one is pure cleanup.

Thanks!
Rusty.

  reply	other threads:[~2011-12-19  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15  3:19 [PATCH 13/15] module_param: make bool parameters really bool (sound) Rusty Russell
2011-12-15  3:19 ` Rusty Russell
2011-12-15 12:33 ` Takashi Iwai
2011-12-19  1:55   ` Rusty Russell [this message]
2011-12-19  9:36     ` Takashi Iwai
2011-12-19  9:36       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762hdpboj.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.