From: Chris Ball <cjb@laptop.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: linux-mmc@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH] mmc: core: Fix typo at mmc_card_sleep
Date: Wed, 16 Nov 2011 23:41:18 -0500 [thread overview]
Message-ID: <8762ijicnl.fsf@laptop.org> (raw)
In-Reply-To: <20111117043433.GA32665@july> (Kyungmin Park's message of "Thu, 17 Nov 2011 13:34:33 +0900")
Hi,
On Wed, Nov 16 2011, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Fix wrong bus_ops->sleep check.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 5278ffb..193e449 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -2196,7 +2196,7 @@ int mmc_card_sleep(struct mmc_host *host)
>
> mmc_bus_get(host);
>
> - if (host->bus_ops && !host->bus_dead && host->bus_ops->awake)
> + if (host->bus_ops && !host->bus_dead && host->bus_ops->sleep)
> err = host->bus_ops->sleep(host);
>
> mmc_bus_put(host);
>
Thanks, applied to mmc-next for 3.2.
(My understanding is that this isn't going to have any real-world
consequences, since the only bus that defines awake or sleep is
core/mmc.c, and it defines both of them.)
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-11-17 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 4:34 [PATCH] mmc: core: Fix typo at mmc_card_sleep Kyungmin Park
2011-11-17 4:41 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762ijicnl.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.