From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO2DB-0001Ae-A1 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 02:04:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RO2DA-0005E3-8Z for qemu-devel@nongnu.org; Wed, 09 Nov 2011 02:04:41 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:44223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO2DA-0005DN-4p for qemu-devel@nongnu.org; Wed, 09 Nov 2011 02:04:40 -0500 Received: from /spool/local by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Nov 2011 02:04:34 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA9739JD215026 for ; Wed, 9 Nov 2011 02:03:15 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA9738CH002761 for ; Wed, 9 Nov 2011 02:03:09 -0500 From: "Aneesh Kumar K.V" In-Reply-To: <1320762230-14134-1-git-send-email-avi@redhat.com> References: <1320762230-14134-1-git-send-email-avi@redhat.com> Date: Wed, 09 Nov 2011 12:33:00 +0530 Message-ID: <8762it93rv.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1.0] configure: fix detection for xattr.h on modern distributions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , qemu-devel@nongnu.org, Anthony Liguori On Tue, 8 Nov 2011 16:23:50 +0200, Avi Kivity wrote: > Modern distributions place xattr.h in /usr/include/sys, and fold > libattr.so into libc. They also don't have an ENOATTR. > > Make configure detect this, and add a qemu-xattr.h file that > directs the #include to the right place. > > Signed-off-by: Avi Kivity > --- > configure | 8 ++++++++ > hw/9pfs/virtio-9p-handle.c | 2 +- > hw/9pfs/virtio-9p-local.c | 2 +- > hw/9pfs/virtio-9p-posix-acl.c | 2 +- > hw/9pfs/virtio-9p-xattr.h | 2 +- > linux-user/syscall.c | 2 +- > qemu-xattr.h | 30 ++++++++++++++++++++++++++++++ > 7 files changed, 43 insertions(+), 5 deletions(-) > create mode 100644 qemu-xattr.h > > diff --git a/configure b/configure > index 9e5da44..5158015 100755 > --- a/configure > +++ b/configure > @@ -129,6 +129,7 @@ xen="" > xen_ctrl_version="" > linux_aio="" > attr="" > +attr_in_sys="" > xfs="" > > vhost_net="no" > @@ -1967,6 +1968,10 @@ EOF > if compile_prog "" "-lattr" ; then > attr=yes > LIBS="-lattr $LIBS" > + # On Fedora 15, there is no attr/xattr.h, and no -lattr: > + elif sed -i s,attr/,sys/, $TMPC && compile_prog "" "" ; then But Fedora 15 also provide libattr-2.4.44-7.fc15.x86_64 libattr-devel-2.4.44-7.fc15.x86_64 I guess we should first check whether sys/xattr.h is available and then check for libattr.so. That will avoid linking qemu to libattr if xattr functions are provided by libc -aneesh