From: Kevin Hilman <khilman@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: Mike Turquette <mturquette@ti.com>, Nishanth Menon <nm@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/8] OMAP3+: PM: VP: generalize PRM interrupt helpers
Date: Fri, 09 Sep 2011 11:41:11 -0700 [thread overview]
Message-ID: <8762l1woc8.fsf@ti.com> (raw)
In-Reply-To: <CAORVsuXzyfWHNyM1u=bXwnhM=yLfF_Q2SS3wjv9n-13mvHcYgw@mail.gmail.com> (Jean Pihet's message of "Wed, 7 Sep 2011 21:27:07 +0200")
Jean Pihet <jean.pihet@newoldbits.com> writes:
> Mike, Kevin,
>
> On Thu, Jun 30, 2011 at 2:25 AM, Mike Turquette <mturquette@ti.com> wrote:
>> From: Nishanth Menon <nm@ti.com>
>>
>> We have multiple interrupt status hidden in the PRM interrupt status
>> reg. Make this handling generic to allow us to pull out LDO status such
>> as those for ABB from it using the same data structure and indexing. We
>> hence rename accordingly.
> I am not sure that the rename is needed.
>
> Kevin, Nishant, what is your opinion?
Rename is mostly fine.
I think the patch is correct, since the interrupts are technically for
the the whole PRM, not just the VP.
However, I don't like the s/vp_id/irq_id/ in the APIs, because the APIs
are intended to be VP specific.
I'll likely pull/fold the parts I agree with into the original patch in
my VP cleanup series
Kevin
next prev parent reply other threads:[~2011-09-09 18:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 0:25 [PATCH 0/8] OMAP3+: Voltage: introduce Adaptive Body-Bias ldo suppport Mike Turquette
2011-06-30 0:25 ` [PATCH 1/8] OMAP3630: PRM: add ABB PRM register definitions Mike Turquette
2011-06-30 0:25 ` [PATCH 2/8] OMAP3+: PM: VP: generalize PRM interrupt helpers Mike Turquette
2011-09-07 19:27 ` Jean Pihet
2011-09-09 18:41 ` Kevin Hilman [this message]
2011-09-09 21:36 ` Kevin Hilman
2011-06-30 0:25 ` [PATCH 3/8] OMAP3+: PRM: add tranxdone IRQ handlers for ABB Mike Turquette
2011-06-30 0:25 ` [PATCH 4/8] OMAP3+: ABB: Adaptive Body-Bias structures & data Mike Turquette
2011-09-07 19:57 ` Jean Pihet
2011-06-30 0:25 ` [PATCH 5/8] OMAP3+: OPP: add ABB data to voltage tables Mike Turquette
2011-06-30 0:25 ` [PATCH 6/8] OMAP3+: Voltage: add ABB data to voltage domains Mike Turquette
2011-06-30 0:25 ` [PATCH 7/8] OMAP3+: ABB: initialization & transition functions Mike Turquette
2011-09-07 20:09 ` Jean Pihet
2011-06-30 0:26 ` [PATCH 8/8] OMAP3+: Voltage: add ABB to voltage scaling Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762l1woc8.fsf@ti.com \
--to=khilman@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.