Re: [pm-wip/voltdm_nm][PATCH 02/10] OMAP4: PM: VC: allow channels use of default channel i2c_slaveaddr

[Kevin Hilman <khilman@ti.com>]

Kevin Hilman <khilman@ti.com> writes:

[...]

>> diff --git a/arch/arm/mach-omap2/voltage.h b/arch/arm/mach-omap2/voltage.h
>> index f079167..1732258 100644
>> --- a/arch/arm/mach-omap2/voltage.h
>> +++ b/arch/arm/mach-omap2/voltage.h
>> @@ -109,6 +109,15 @@ struct omap_volt_data {
>>  	u8	vp_errgain;
>>  };
>>  
>> +/*
>> + * Introduced in OMAP4, is a concept of a default channel - in OMAP4, this
>> + * channel is MPU, all other domains such as IVA/CORE, could optionally
>> + * link their i2c reg configuration to use MPU channel's configuration if
>> + * required. To do this, mark in the PMIC structure's
>> + * i2c_slave_addr with this macro.
>> + */
>> +#define USE_DEFAULT_CHANNEL_I2C_PARAM  0x8000
>> +
>
> Needs a VC prefix, also use BIT().  
>
> Also, later on in the series you use the same value for things other
> than the I2C slave address.  How about just calling this:
>
> #define OMAP_VC_USE_DEFAULT_CHANNEL    BIT(15)
>

Also, this should be in vc.h, not voltage.h

Kevin