From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH V3 04/19] OMAP3+: voltage: remove spurious pr_notice for debugfs Date: Thu, 17 Mar 2011 07:55:00 -0700 Message-ID: <8762rhbxvf.fsf@ti.com> References: <1299338962-5602-1-git-send-email-nm@ti.com> <1299338962-5602-5-git-send-email-nm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog104.obsmtp.com ([74.125.149.73]:52621 "EHLO na3sys009aog104.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753782Ab1CQOzE (ORCPT ); Thu, 17 Mar 2011 10:55:04 -0400 Received: by mail-iy0-f176.google.com with SMTP id 12so3506891iyj.21 for ; Thu, 17 Mar 2011 07:55:03 -0700 (PDT) In-Reply-To: <1299338962-5602-5-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sat, 5 Mar 2011 20:59:07 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Nishanth Menon Cc: linux-omap , linux-arm , Tony , Paul Nishanth Menon writes: > cat of debugfs entry for vp_volt provides voltage. The additional pr_notice > is just spam on console and provides no additional information. > > Signed-off-by: Nishanth Menon Thanks, queueing for 2.6.39-rc fixes cycle. Kevin > --- > arch/arm/mach-omap2/voltage.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c > index 1b40aa0..53c399f 100644 > --- a/arch/arm/mach-omap2/voltage.c > +++ b/arch/arm/mach-omap2/voltage.c > @@ -150,7 +150,6 @@ static int vp_volt_debug_get(void *data, u64 *val) > } > > vsel = vdd->read_reg(prm_mod_offs, vdd->vp_data->voltage); > - pr_notice("curr_vsel = %x\n", vsel); > > if (!vdd->pmic_info->vsel_to_uv) { > pr_warning("PMIC function to convert vsel to voltage" From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Thu, 17 Mar 2011 07:55:00 -0700 Subject: [PATCH V3 04/19] OMAP3+: voltage: remove spurious pr_notice for debugfs In-Reply-To: <1299338962-5602-5-git-send-email-nm@ti.com> (Nishanth Menon's message of "Sat, 5 Mar 2011 20:59:07 +0530") References: <1299338962-5602-1-git-send-email-nm@ti.com> <1299338962-5602-5-git-send-email-nm@ti.com> Message-ID: <8762rhbxvf.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Nishanth Menon writes: > cat of debugfs entry for vp_volt provides voltage. The additional pr_notice > is just spam on console and provides no additional information. > > Signed-off-by: Nishanth Menon Thanks, queueing for 2.6.39-rc fixes cycle. Kevin > --- > arch/arm/mach-omap2/voltage.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c > index 1b40aa0..53c399f 100644 > --- a/arch/arm/mach-omap2/voltage.c > +++ b/arch/arm/mach-omap2/voltage.c > @@ -150,7 +150,6 @@ static int vp_volt_debug_get(void *data, u64 *val) > } > > vsel = vdd->read_reg(prm_mod_offs, vdd->vp_data->voltage); > - pr_notice("curr_vsel = %x\n", vsel); > > if (!vdd->pmic_info->vsel_to_uv) { > pr_warning("PMIC function to convert vsel to voltage"