From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] davinci: Add MityDSP-L138/MityARM-1808 SOM support
Date: Fri, 27 Aug 2010 07:11:58 -0700 [thread overview]
Message-ID: <8762ywrvpt.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4C7702EB.8040905@criticallink.com> (Michael Williamson's message of "Thu, 26 Aug 2010 20:12:27 -0400")
Michael Williamson <michael.williamson@criticallink.com> writes:
>> Normally, I like to see new board support broken down more. It's rather
>> difficult to do a good review of new board file when everything is added
>> in a single patch.
>>
>> Typically, a basic patch that just supports basic boot (typically to
>> UART console) is the first patch. Then additional patches are added to
>> add peripheral support (display, MMC, SPI, flash, regulators, ...)
>>
>> Breaking things up this way helps reviewers and maintainers greatly.
>>
>> [...]
>>
> OK. Most of the board file is a large cut-and-paste of the da850
> EVM. It seems unlikely that I'll have any measure of success here, but if
> I get time I might try again.
OK, if it's mostly a cut-and-paste of da850, then maybe just break it up
into two patches, 1) the cut, paste & rename patch and 2) a separate
patch for things that are different on your board.
Thanks,
Kevin
next prev parent reply other threads:[~2010-08-27 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 11:29 [PATCH v4] davinci: Add MityDSP-L138/MityARM-1808 SOM support Michael Williamson
2010-08-26 22:25 ` Kevin Hilman
2010-08-27 0:12 ` Michael Williamson
2010-08-27 11:12 ` Michael Williamson
2010-08-27 14:11 ` Kevin Hilman [this message]
2010-08-27 16:24 ` Michael Williamson
2010-08-27 18:05 ` Kevin Hilman
2010-08-28 13:26 ` mmc over SPI on DM6467 based board. card not detected Sumesh Kaana
2010-08-30 13:27 ` Steve Chen
2010-09-01 11:41 ` Martin Guy
2010-09-02 14:18 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762ywrvpt.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.