From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [patch] i915: missing unlock on error path Date: Wed, 26 May 2010 14:18:30 -0700 Message-ID: <87632al5uh.fsf@pollan.anholt.net> References: <20100507083701.GW27064@bicker> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6818962933183220142==" Return-path: In-Reply-To: <20100507083701.GW27064@bicker> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Dan Carpenter , David Airlie Cc: =?utf-8?Q?H=C3=B8gsberg?= , jirislaby@gmail.com, Jesse Barnes , Kristian, dri-devel@lists.sourceforge.net List-Id: dri-devel@lists.freedesktop.org --===============6818962933183220142== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 7 May 2010 10:37:01 +0200, Dan Carpenter wrote: > There was a missing mutex_unlock(&dev->struct_mutex) on this error path. >=20 > Signed-off-by: Dan Carpenter > --- > I thought Jiri sent this patch earlier but a google search for "stanse > struct_mutex i965_reset" didn't find any patches, so I'm resending. >=20 > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index 01e91ea..a605c87 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -369,6 +369,7 @@ int i965_reset(struct drm_device *dev, u8 flags) > } > } else { > DRM_ERROR("Error occurred. Don't know how to reset this chip.\n"); > + mutex_unlock(&dev->struct_mutex); > return -ENODEV; > } >=20=20 Heh, got another version of this patch from Daniel J Blueman and ended up applying his first as I went through my tag:todo list. Thanks, though! --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkv9kCYACgkQHUdvYGzw6vd/5ACdH4da6+u500jNNbdZ/1/arkig lo8An0rNDGr30h7kp3FMYpi4VOCZt43R =3iBS -----END PGP SIGNATURE----- --=-=-=-- --===============6818962933183220142== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ --===============6818962933183220142== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel --===============6818962933183220142==--