All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
	Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 4/6] OMAP: hwmod: Temporary disable dependency
Date: Thu, 20 May 2010 10:25:42 -0700	[thread overview]
Message-ID: <87632ifpt5.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1273248424-15943-5-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Fri\,  7 May 2010 18\:07\:02 +0200")

Benoit Cousson <b-cousson@ti.com> writes:

> From: Rajendra Nayak <rnayak@ti.com>
>
> Dependency not supported yet, hence comment all dependency handling
> code in hwmod.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 2fff39f..302f2c8 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -908,7 +908,9 @@ static int _enable(struct omap_hwmod *oh)
>  
>  	/* XXX mux balls */
>  
> +#if 0
>  	_add_initiator_dep(oh, mpu_oh);
> +#endif
>  	_enable_clocks(oh);
>  
>  	r = _wait_target_ready(oh);
> @@ -949,7 +951,9 @@ static int _idle(struct omap_hwmod *oh)
>  
>  	if (oh->class->sysc)
>  		_sysc_idle(oh);
> +#if 0
>  	_del_initiator_dep(oh, mpu_oh);
> +#endif

At least, the temporaty hack should use cpu_is_* as to not
break OMAP3.

Kevin

  reply	other threads:[~2010-05-20 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 16:06 [PATCH 0/6] OMAP: hwmod: Full data set for OMAP4430 ES1.0 Benoit Cousson
2010-05-07 16:06 ` [PATCH 1/6] OMAP4: hwmod: Add partial hwmod support " Benoit Cousson
2010-05-07 16:07 ` [PATCH 2/6] OMAP4: hwmod: Enable omap_hwmod build for OMAP4 Benoit Cousson
2010-05-07 16:07 ` [PATCH 3/6] OMAP4: hwmod: Enable omap_device " Benoit Cousson
2010-05-07 16:10   ` Benoit Cousson
2010-05-07 20:33   ` Tony Lindgren
2010-05-10 10:00     ` Benoit Cousson
2010-05-07 16:07 ` [PATCH 4/6] OMAP: hwmod: Temporary disable dependency Benoit Cousson
2010-05-20 17:25   ` Kevin Hilman [this message]
2010-05-07 16:07 ` [PATCH 5/6] OMAP4: hwmod: Add remaining hwmod support for OMAP4430 ES1.0 Benoit Cousson
2010-05-07 16:07 ` [PATCH 6/6] OMAP: hwmod: Temp fixes to get hwmod registers work Benoit Cousson
2010-05-20 17:26   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87632ifpt5.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=b-cousson@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.