All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Poole <mdpoole@troilus.org>
To: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <tissoire@tls.cena.fr>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Stephane Chatty <chatty@enac.fr>
Subject: [PATCH 0/1] hid-magicmouse: Emulate horizontal scrolling.
Date: Mon, 08 Mar 2010 19:55:36 -0500	[thread overview]
Message-ID: <8763562u0n.fsf@troilus.org> (raw)

This patch is separate from the changes about input device registration,
except for having some context lines in common with Benjamin's patch.  I
found a use case for horizontal scrolling while moving left to right in
an OpenOffice.org spreadsheet, and this gesture seems basic enough to
merit inclusion in the kernel.

Some areas that may deserve revision or more attention before commit:

1) It might make sense to separately commit the parameter for the
acceleration profile.  I didn't do that because they touch the same code
and exporting the module parameter is so few lines.

2) The acceleration profile is faster than the original, which was not
as responsive as my mice with physical scroll wheels.  However, the
horizontal scrolling may be a little too sensitive: I have to be
somewhat careful to only drag vertically, or else it will generate
horizontal scroll events.  This would be fixable using a different
scroll_accel_profile-like array for each direction.  Other potential
solutions (such as heuristics to guess the direction of the swipe)
seemed better left to user space.

3) The initial calculation of num_scroll_accel_profile is not pretty.
It seemed marginally better to calculate it at module load time than
hard-code the default value, but that's debatable.  I don't see a
reasonable way to calculate the default value at compile time.

Michael Poole

             reply	other threads:[~2010-03-09  0:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09  0:55 Michael Poole [this message]
2010-03-09  0:58 ` [PATCH 1/1] hid-magicmouse: Emulate horizontal scrolling Michael Poole
2010-03-09  7:50   ` Dmitry Torokhov
2010-03-09 11:40     ` Michael Poole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763562u0n.fsf@troilus.org \
    --to=mdpoole@troilus.org \
    --cc=chatty@enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=tissoire@tls.cena.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.