From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MqZAf-0007CS-EJ
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MqZAZ-000790-6g
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:39 -0400
Received: from [199.232.76.173] (port=54999 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MqZAY-00078j-RW
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27057)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1MqZAY-0005QE-Df
	for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NLEXCP021403
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2009 17:14:33 -0400
Subject: Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of
	silently exiting
References: <1253704471-30740-1-git-send-email-amit.shah@redhat.com>
From: Markus Armbruster <armbru@redhat.com>
Date: Wed, 23 Sep 2009 22:53:27 +0200
In-Reply-To: <1253704471-30740-1-git-send-email-amit.shah@redhat.com> (Amit
	Shah's message of "Wed\, 23 Sep 2009 16\:44\:31 +0530")
Message-ID: <8763b97588.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

Amit Shah <amit.shah@redhat.com> writes:

> If initializing a device fails, show the name of the device
> and then exit

"and then exit" is misleading, as you don't add an exit.

> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  hw/qdev.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 1d79db0..62a6fc7 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -203,6 +203,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
>          return NULL;
>      }
>      if (qdev_init(qdev) != 0) {
> +        qemu_error("Error initializing device %s\n", driver);
>          qdev_free(qdev);
>          return NULL;
>      }