From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MWn5H-000482-1J for mharc-grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWn5G-00047B-9K for grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWn5B-00040E-HK for grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:21 -0400 Received: from [199.232.76.173] (port=40267 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWn5B-000403-Ck for grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:17 -0400 Received: from mx20.gnu.org ([199.232.41.8]:32984) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWn5A-0004Zp-QS for grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:17 -0400 Received: from smtp-vbr7.xs4all.nl ([194.109.24.27]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWn5A-0003M5-1u for grub-devel@gnu.org; Fri, 31 Jul 2009 04:03:16 -0400 Received: from marco (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr7.xs4all.nl (8.13.8/8.13.8) with ESMTP id n6V83EMg024868 for ; Fri, 31 Jul 2009 10:03:14 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1245429440.28417.29.camel@mj> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 31 Jul 2009 10:03:13 +0200 In-Reply-To: <1245429440.28417.29.camel@mj> (Pavel Roskin's message of "Fri, 19 Jun 2009 12:37:20 -0400") Message-ID: <8763d9wa7y.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-Detected-Operating-System: by mx20.gnu.org: FreeBSD 4.6-4.9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: Proposal for GNU indent compatibility X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 08:03:22 -0000 Hi, Pavel Roskin writes: > In order to encourage developers to use proper indentation on the newly > added code, I suggest that we accept the default style of GNU indent. > That is, the space after "!" should not be needed. That's the only > difference I'm aware of. > > Running indent on the code and then adding spaces after "!" is > ridiculous, in my opinion. GRUB and indent are both GNU programs, it > should not be needed to do such things. > > That doesn't mean that we should start reformatting the existing code. > Neither does it mean that it's acceptable to submit code that GNU indent > failed to format nicely. I do not have a problem with this. Thus the space change around "!". -- Marco