From: Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] C/R: simplify checkpoint debugging
Date: Mon, 22 Jun 2009 14:07:31 -0700 [thread overview]
Message-ID: <8763eo6kq4.fsf@caffeine.danplanet.com> (raw)
In-Reply-To: <20090622204059.GB5537-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> (Serge E. Hallyn's message of "Mon\, 22 Jun 2009 15\:40\:59 -0500")
SH> Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
>> To enable printing of checkpoint/restart messages, one must enable
>> CHECKPOINT_DEBUG and boot with ckpt_debug= ... something I haven't
>> been able to figure out. Further complicating matters is that if
>> DYNAMIC_DEBUG is enabled, you still won't get any debugging output
>> unless you manually enable debug output for all the functions you're
>> interested in via <debugfs>/dynamic_debug/control. At this stage of
>> development most users will want all C/R messages either on or off and
>> don't need a fancy filtering mechanism.
>>
>> Change ckpt_debug to print messages if CHECKPOINT_DEBUG=y. Otherwise
>> it will emit nothing. Remove ckpt_debug= setup code. Reword
>> CHECKPOINT_DEBUG config help text appropriately.
>>
>> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
SH> Yes please!
Enthusiastically seconded. Or thirded, or whatever it would be.
--
Dan Smith
IBM Linux Technology Center
email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
next prev parent reply other threads:[~2009-06-22 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 19:37 [PATCH] C/R: simplify checkpoint debugging Nathan Lynch
[not found] ` <m33a9st5yk.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-06-22 20:40 ` Serge E. Hallyn
[not found] ` <20090622204059.GB5537-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-22 21:07 ` Dan Smith [this message]
2009-06-24 16:49 ` Oren Laadan
[not found] ` <4A425927.6080109-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-06-24 19:02 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763eo6kq4.fsf@caffeine.danplanet.com \
--to=danms-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.