From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Hald, Ulrik Bech" <ubh@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/3] OMAP3:WDT:Enable support for IVA and SECURE
Date: Mon, 15 Jun 2009 09:26:17 -0700 [thread overview]
Message-ID: <8763exa2fq.fsf@deeprootsystems.com> (raw)
In-Reply-To: <00695C9C8F8B4448856F48142B4AA201BD868426@dnce02.ent.ti.com> (Ulrik Bech Hald's message of "Mon\, 15 Jun 2009 18\:19\:11 +0200")
"Hald, Ulrik Bech" <ubh@ti.com> writes:
[...]
>> >>
>> >> Again, red flag: cpu_is_*
>> >>
>> >> It might be more consistent to use pdev->dev->name which is already of
>> >> the form "watchdog.%d".
>> >
>> > Not sure I follow. I don't see a "name" field in struct device, only
>> init_name.
>>
>> Sorry, I meant dev->bus_id. Look at dev_set_name() which creates
>> a bus_id of the form ("%s.%d", pdev->name, pdev->id)
>
> As far as I can see, dev->bus_id has been removed from the device
> struct as per 1fa5ae857bb14f6046205171d98506d8112dd74e.
> Furthermore, the pdev->name is "omap_wdt", which should be presented
> as "watchdog" in wdev->omap_wdt_miscdev.name anyway, so I think I'll
> just go with the sprintf() approach below, keeping your wdt_name
> comments in mind.
OK
Kevin
next prev parent reply other threads:[~2009-06-15 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 21:08 [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes Ulrik Bech Hald
2009-06-08 21:08 ` [PATCH 1/3] OMAP3:WDT:Register IVA,SECURE, make clks accessible Ulrik Bech Hald
2009-06-08 21:08 ` [PATCH 2/3] OMAP3:WDT:Enable support for IVA and SECURE Ulrik Bech Hald
2009-06-08 21:08 ` [PATCH 3/3] OMAP3:WDT:Enable clk in probe, trigger timer reload Ulrik Bech Hald
2009-06-09 14:47 ` [PATCH 2/3] OMAP3:WDT:Enable support for IVA and SECURE Kevin Hilman
2009-06-09 19:28 ` Hald, Ulrik Bech
2009-06-09 21:10 ` Kevin Hilman
2009-06-15 16:19 ` Hald, Ulrik Bech
2009-06-15 16:26 ` Kevin Hilman [this message]
2009-06-09 14:45 ` [PATCH 0/3] OMAP3:WDT:Enable IVA, SECURE and minor bugfixes Kevin Hilman
2009-06-09 18:02 ` Hald, Ulrik Bech
2009-06-09 18:16 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763exa2fq.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=ubh@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.