From: Miles Bader <miles@gnu.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit
Date: Sun, 03 May 2009 09:50:36 +0900 [thread overview]
Message-ID: <8763gjdn6r.fsf@catnip.gol.com> (raw)
In-Reply-To: <20090503001423.GO23604@spearce.org> (Shawn O. Pearce's message of "Sat, 2 May 2009 17:14:23 -0700")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> And here is that hack. It just feels wrong to me that I need
> to subtract 1 from the Edit region's line numbers, *only* when
> context is 0, in order to get the same output as CGit.
A big comment saying "this may look a bit funny, but it's the standard's
fault: [text from std...]" might help salve the wound...
-Miles
--
.Numeric stability is probably not all that important when you're guessing.
next prev parent reply other threads:[~2009-05-03 0:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 0:05 [JGIT PATCH 7/6] BROKEN: Add a zero line context test for diff.DiffFormatter Shawn O. Pearce
2009-05-03 0:14 ` [JGIT PATCH 8/6] Fix zero context insert and delete hunk headers to match CGit Shawn O. Pearce
2009-05-03 0:50 ` Miles Bader [this message]
2009-05-03 8:25 ` Robin Rosenberg
2009-05-03 8:31 ` Ferry Huberts (Pelagic)
2009-05-03 9:24 ` Robin Rosenberg
2009-05-03 9:29 ` Ferry Huberts (Pelagic)
2009-05-05 22:19 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763gjdn6r.fsf@catnip.gol.com \
--to=miles@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.