Re: [PATCH] Add ov772x driver

[Robert Jarzmik <robert.jarzmik@free.fr>]

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> Hm, so, to test your camera you have to modify your source and rebuild 
> your kernel... And same again to switch back to normal operation. Does not 
> sound very convenient to me. OTOH, making it a module parameter makes it 
> much easier. In fact, maybe it would be a good idea to add a new 
> camera-class control for this mode. Yet another possibility is to enable 
> debug register-access in the driver and use that to manually set the test 
> mode from user-space. A new v4l-control seems best to me, not sure what 
> others will say about this. As you probably know, many other cameras also 
> have this "test pattern" mode, some even several of them. So, this becomes 
> a control with a parameter then.

Personnaly I'm rather inclined for the debug registers solutions.

When developping a camera driver, the test pattern alone is not enough. You have
to tweak the registers, see if the specification is correct, then understand the
specification, and then change your driver code. My experience tells me you
never understand correctly are camera setup from the first time.

So IMHO the registers are enough here.

> Then a new control or raw register access would be a better way, I think.
So do I.

Cheers.

--
Robert

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list