From: Andi Kleen <andi@firstfloor.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Holger Macht <hmacht@suse.de>, mjg59 <mjg59@srcf.ucam.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [patch 3/11]add _LCK support for dock
Date: Thu, 28 Aug 2008 01:09:59 +0200 [thread overview]
Message-ID: <8763pmqcl4.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1219806871.32665.59.camel@sli10-desk.sh.intel.com> (Shaohua Li's message of "Wed, 27 Aug 2008 11:14:31 +0800")
Shaohua Li <shaohua.li@intel.com> writes:
> +static void dock_lock(struct dock_station *ds, int lock)
> +{
> + struct acpi_object_list arg_list;
> + union acpi_object arg;
> + acpi_status status;
> +
> + arg_list.count = 1;
> + arg_list.pointer = &arg;
> + arg.type = ACPI_TYPE_INTEGER;
> + arg.integer.value = !!lock;
> + status = acpi_evaluate_object(ds->handle, "_LCK", &arg_list, NULL);
> + if (ACPI_FAILURE(status) && status != AE_NOT_FOUND)
> + printk(KERN_WARNING PREFIX "%s device failed\n",
> + lock ? "Locking" : "Unlocking");
Please use two printks -- that makes the error message greppable.
Output the status and some identifier for the device? Otherwise
the user will have no clue what device failed.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-08-27 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 3:14 [patch 3/11]add _LCK support for dock Shaohua Li
2008-08-27 23:09 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-28 2:03 Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763pmqcl4.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hmacht@suse.de \
--cc=hmh@hmh.eng.br \
--cc=htejun@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.