From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQMMX-0007Pk-Et for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 09:14:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQMMV-0007P0-Ve for grub-devel@gnu.org; Tue, 05 Aug 2008 09:14:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQMMU-0007OU-Gh for grub-devel@gnu.org; Tue, 05 Aug 2008 09:14:03 -0400 Received: from [199.232.76.173] (port=42449 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQMMU-0007OR-8G for grub-devel@gnu.org; Tue, 05 Aug 2008 09:14:02 -0400 Received: from smtp-vbr10.xs4all.nl ([194.109.24.30]:1104) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQMMT-0002ws-PV for grub-devel@gnu.org; Tue, 05 Aug 2008 09:14:02 -0400 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr10.xs4all.nl (8.13.8/8.13.8) with ESMTP id m75DE0JW081855 for ; Tue, 5 Aug 2008 15:14:01 +0200 (CEST) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20080721180723.GC7501@pina.cat> <20080805120200.GA15143@pina.cat> Mail-Copies-To: mgerards@xs4all.nl Date: Tue, 05 Aug 2008 15:16:39 +0200 In-Reply-To: <20080805120200.GA15143@pina.cat> (Carles Pina i. Estany's message of "Tue, 5 Aug 2008 14:02:00 +0200") Message-ID: <8763qfeh54.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Home-End keys in menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 13:14:04 -0000 Hi, Carles Pina i Estany writes: > Some weeks ago I sent a patch that didn't have any discussion. I'm > sending it again, maybe everybody was in holidays :-) > > Actually I updated the patch (added some spaces to comply with the > coding style). > > * menu/normal.c: Add Home and End keys in grub-menu The first line of the changelog entry is missing (name + e-mail address). Please mention the function you change like: * menu/normal.c (foo): Blah blah. And end a sentence with a "." >> Index: normal/menu.c >> =================================================================== >> --- normal/menu.c (revision 1718) >> +++ normal/menu.c (working copy) >> @@ -405,6 +405,22 @@ >> >> switch (c) >> { >> + case GRUB_TERM_HOME: >> + first=0; >> + offset=0; >> + print_entries (menu, first, offset); >> + break; The indentation of the case statement doesn't seem right... >> + case GRUB_TERM_END: >> + offset = menu->size - 1; >> + if (offset > GRUB_TERM_NUM_ENTRIES - 1) >> + { >> + first = offset - (GRUB_TERM_NUM_ENTRIES - 1); >> + offset = GRUB_TERM_NUM_ENTRIES - 1; This indentation also looks funny... >> + } >> + print_entries (menu, first, offset); >> + break; >> + >> case 16: >> case '^': >> if (offset > 0) > >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel > > -- > Carles Pina i Estany GPG id: 0x17756391 > http://pinux.info > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel