From: Markus Armbruster <armbru@redhat.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] ioemu: Fix PVFB backend to limit frame buffer size
Date: Thu, 15 May 2008 09:53:01 +0200 [thread overview]
Message-ID: <8763tgatr6.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <877idyxq1i.fsf@pike.pond.sub.org> (Markus Armbruster's message of "Tue\, 13 May 2008 16\:00\:09 +0200")
The recent fix to validate the frontend's frame buffer description
neglected to limit the frame buffer size correctly. This lets a
malicious frontend make the backend attempt to map an arbitrary amount
of guest memory, which could be useful for a denial of service attack
against dom0.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
diff -r 53195719f762 tools/ioemu/hw/xenfb.c
--- a/tools/ioemu/hw/xenfb.c Tue May 13 15:08:17 2008 +0100
+++ b/tools/ioemu/hw/xenfb.c Thu May 15 09:37:18 2008 +0200
@@ -502,6 +502,7 @@ static int xenfb_configure_fb(struct xen
fprintf(stderr,
"FB: frontend fb size %zu limited to %zu\n",
fb_len, fb_len_lim);
+ fb_len = fb_len_lim;
}
if (depth != 8 && depth != 16 && depth != 24 && depth != 32) {
fprintf(stderr,
next prev parent reply other threads:[~2008-05-15 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 14:00 Fix PVFB backend to validate frontend's frame buffer description Markus Armbruster
2008-05-14 18:04 ` Pat Campbell
2008-05-15 7:40 ` Markus Armbruster
2008-05-15 7:53 ` Markus Armbruster [this message]
2008-05-19 13:06 ` [PATCH] ioemu: Fix interpretation of missing or zero vfb videoram Markus Armbruster
2008-05-19 12:02 ` Fix PVFB backend to validate frontend's frame buffer description Yosuke Iwamatsu
2008-05-19 12:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763tgatr6.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.