From: "Markus Klotzbücher" <mk@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Propagate Error Status to the Shell on fw_printenv Errors
Date: Wed, 07 May 2008 16:49:19 +0200 [thread overview]
Message-ID: <8763tqgoeo.fsf@denx.de> (raw)
In-Reply-To: <C4470263.F0B2%gerickson@nuovations.com> (Grant Erickson's message of "Wed\, 07 May 2008 06\:53\:23 -0700")
Dear Grant,
Grant Erickson <gerickson@nuovations.com> writes:
> Thanks for the comments. As suggested by Wolfgang, the "-n" option was
> pre-existing in the code before my patch.
>
> I can investigate extending "-n" as described above; however, the caveat is
> that the user knows that the values of some variables may have spaces. In
> such a case, he/she might find the above example to not work as expected.
Thats right, but then that's a problem the user needs to be aware of.
> Anyway, hopefully Wolfgang can ACK the patch as is and I can look at
> extending the "-n" option as another separate effort.
Ok, fine!
> PS: To which documentation are you referring? The comments in the source or
> the DULG?
The README in the tools/env/ directory. As you're fixing a bug (opposed
to adding a feature) there's no obligation really to do this, but it
would be great anyway :-)
And I can take care of updating the DULG.
Thanks!
Markus Klotzbuecher
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2008-05-07 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 3:16 [U-Boot-Users] [PATCH] Propagate Error Status to the Shell on fw_printenv Errors Grant Erickson
2008-05-07 6:44 ` Markus Klotzbücher
2008-05-07 7:10 ` Wolfgang Denk
2008-05-07 7:32 ` Markus Klotzbücher
2008-05-07 13:53 ` Grant Erickson
2008-05-07 14:49 ` Markus Klotzbücher [this message]
2008-05-07 15:50 ` Wolfgang Denk
2008-05-07 13:56 ` Grant Erickson
2008-05-07 15:55 ` Wolfgang Denk
2008-05-07 7:29 ` Joakim Tjernlund
2008-05-07 14:01 ` Grant Erickson
2008-05-09 21:41 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763tqgoeo.fsf@denx.de \
--to=mk@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.