All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: David Brownell <david-b@pacbell.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-serial@vger.kernel.org, kay@ascent
Subject: Re: [patch 2.6.25-rc9] serial: fix platform driver hotplug/coldplug
Date: Sun, 13 Apr 2008 20:39:57 +0200	[thread overview]
Message-ID: <8763ulzjia.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200804131115.26592.david-b@pacbell.net> (David Brownell's message of "Sun\, 13 Apr 2008 11\:15\:26 -0700")

>>>>> "David" == David Brownell <david-b@pacbell.net> writes:

Hi,

 David>  MODULE_LICENSE("GPL");
 David> +MODULE_ALIAS("platform:sh-sci");
 David> --- g26.orig/drivers/serial/uartlite.c	2008-04-13 10:48:05.000000000 -0700
 David> +++ g26/drivers/serial/uartlite.c	2008-04-13 10:59:04.000000000 -0700
 David> @@ -561,6 +561,9 @@ static int __devexit ulite_remove(struct
 David>  	return ulite_release(&pdev->dev);
 David>  }
 
 David> +/* work with hotplug and coldplug */
 David> +MODULE_ALIAS("platform:uartlite");
 David> +

Why not stick this next to the other MODULE_ lines, like the other
drivers?

Other than that ..

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-04-13 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-13 18:15 [patch 2.6.25-rc9] serial: fix platform driver hotplug/coldplug David Brownell
2008-04-13 18:39 ` Peter Korsgaard [this message]
2008-04-13 19:07   ` David Brownell
2008-04-13 19:11     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763ulzjia.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=kay@ascent \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.