From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
Bart Van Assche <bart.vanassche@gmail.com>
Subject: Re: quicklists confuse meminfo
Date: 09 Mar 2008 21:21:38 +0100 [thread overview]
Message-ID: <8763vv1wdp.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080309114640.85c9c3eb.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> writes:
> On Sun, 9 Mar 2008 13:34:32 +0100 Ingo Molnar <mingo@elte.hu> wrote:
>
> > the right solution is to get rid of quicklists altogether
>
> Yes, I think so.
>
> - They are pretty marginal from a performance POV (iirc)
One general issue -- as noted again by Christoph Lameter recently --
is that the order 0 fast path in page_alloc.c isn't actually very
fast. That is why people keep inventing their own...
> - As I said when we merged them (under protest): Private object caches
> like this are just a bad idea - caches should be *shared*, because some
> other code path which wants a zeroed page wants a cache-warm one, not a
> cache-cold one from the allocator (iirc there was doubt over how
> cache-warm these pages are, however).
>
> Making __GFP_ZERO smarter/more efficient would be a preferable way of
> addressing any performance problems we have in there.
To do the same as quicklists you would need a __free_pages_zeroed()
and separate buddy lists I think. Later is probably somewhat ugly.
Or perhaps do it only for order 0?
Or perhaps idle time zeroing should be reinvestigated on modern CPUs,
but I'm always a little sceptical of that.
-Andi
next prev parent reply other threads:[~2008-03-09 20:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 10:19 quicklists confuse meminfo Thomas Gleixner
2008-03-09 10:26 ` Bart Van Assche
2008-03-09 10:29 ` Andi Kleen
2008-03-09 10:42 ` KOSAKI Motohiro
2008-03-09 12:00 ` Thomas Gleixner
2008-03-09 11:14 ` Ingo Molnar
2008-03-09 11:56 ` Thomas Gleixner
2008-03-09 12:01 ` Ingo Molnar
2008-03-09 12:49 ` Andi Kleen
2008-03-10 15:51 ` Christoph Lameter
2008-03-09 12:03 ` Johannes Weiner
2008-03-09 12:03 ` KOSAKI Motohiro
2008-03-09 12:09 ` Ingo Molnar
2008-03-09 12:34 ` Ingo Molnar
2008-03-09 12:51 ` KOSAKI Motohiro
2008-03-09 13:20 ` Thomas Gleixner
2008-03-09 18:46 ` Andrew Morton
2008-03-09 20:21 ` Andi Kleen [this message]
2008-03-10 15:54 ` Christoph Lameter
2008-03-10 16:43 ` Andi Kleen
2008-03-10 17:19 ` Hugh Dickins
2008-03-10 17:25 ` Andi Kleen
2008-03-10 17:31 ` Jeremy Fitzhardinge
2008-03-10 17:53 ` Andi Kleen
2008-03-10 18:35 ` Jeremy Fitzhardinge
2008-03-10 19:06 ` Andi Kleen
2008-03-10 20:54 ` H. Peter Anvin
2008-03-10 21:26 ` Jeremy Fitzhardinge
2008-03-11 4:07 ` Nick Piggin
2008-03-21 12:52 ` Bart Van Assche
2008-03-21 14:45 ` Ingo Molnar
2008-03-26 7:45 ` Bart Van Assche
2008-03-26 7:53 ` Andrew Morton
2008-03-26 8:13 ` Ingo Molnar
2008-03-26 10:37 ` Bart Van Assche
2008-03-26 16:34 ` Christoph Lameter
2008-03-27 9:48 ` Bart Van Assche
2008-03-09 19:11 ` Arjan van de Ven
2008-03-09 19:25 ` Ingo Molnar
2008-03-09 19:27 ` Ingo Molnar
2008-03-09 19:31 ` Ingo Molnar
2008-03-10 15:57 ` Christoph Lameter
2008-03-10 15:55 ` Christoph Lameter
2008-03-09 12:47 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763vv1wdp.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=bart.vanassche@gmail.com \
--cc=clameter@sgi.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.