From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IqVoI-0006h0-NC for mharc-grub-devel@gnu.org; Fri, 09 Nov 2007 10:30:18 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqVoG-0006ge-Nd for grub-devel@gnu.org; Fri, 09 Nov 2007 10:30:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqVoF-0006g8-CD for grub-devel@gnu.org; Fri, 09 Nov 2007 10:30:16 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqVoF-0006g5-4o for grub-devel@gnu.org; Fri, 09 Nov 2007 10:30:15 -0500 Received: from smtp-vbr13.xs4all.nl ([194.109.24.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IqVoE-00080R-Gc for grub-devel@gnu.org; Fri, 09 Nov 2007 10:30:14 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr13.xs4all.nl (8.13.8/8.13.8) with ESMTP id lA9FUC8t034277 for ; Fri, 9 Nov 2007 16:30:13 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <20071107205340.GA16687@thorin> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 09 Nov 2007 16:30:44 +0100 In-Reply-To: <20071107205340.GA16687@thorin> (Robert Millan's message of "Wed, 7 Nov 2007 21:53:40 +0100") Message-ID: <87640bl9ln.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] fix serial console on LinuxBIOS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 15:30:16 -0000 Robert Millan writes: > This patch fixes serial console on LinuxBIOS. > > I'd appreciate comments (specially on the addition). > > -- > Robert Millan > > I know my rights; I want my phone call! > What use is a phone call, if you are unable to speak? > (as seen on /.) > No header ;) > * include/grub/i386/efi/machine.h: New file. > * include/grub/i386/linuxbios/machine.h: Likewise. > * include/grub/i386/pc/machine.h: Likewise. > * include/grub/powerpc/ieee1275/machine.h: Likewise. > * include/grub/sparc64/ieee1275/machine.h: Likewise. > > * term/i386/pc/serial.c: Include . > (serial_hw_io_addr): New variable. > (serial_hw_get_port): Obtain port address from `serial_hw_io_addr' > instead of `(unsigned short *) 0x400'. This seems fine to me. What is your intended use for machine.h? More than just this? Perhaps we can even use autoconf to define this in config.h? That would be better I think. -- Marco