From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HATVX-0007Yn-B9 for mharc-grub-devel@gnu.org; Fri, 26 Jan 2007 11:00:55 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HATVV-0007Vb-Fv for grub-devel@gnu.org; Fri, 26 Jan 2007 11:00:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HATVR-0007Ob-NZ for grub-devel@gnu.org; Fri, 26 Jan 2007 11:00:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HATVR-0007OY-LK for grub-devel@gnu.org; Fri, 26 Jan 2007 11:00:49 -0500 Received: from smtp-vbr8.xs4all.nl ([194.109.24.28]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HATVR-0002hy-0r for grub-devel@gnu.org; Fri, 26 Jan 2007 11:00:49 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id l0QG0iOY010731 for ; Fri, 26 Jan 2007 17:00:45 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <1169724331.3386.51.camel@pluto> <200701261258.20645.okuji@enbug.org> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 26 Jan 2007 17:01:22 +0100 In-Reply-To: <200701261258.20645.okuji@enbug.org> (Yoshinori K. Okuji's message of "Fri, 26 Jan 2007 12:58:20 +0100") Message-ID: <8764at6alp.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: FreeBSD 4.6-4.9 Subject: Re: [PATCH] Making use of argp in GRUB utilities X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2007 16:00:54 -0000 "Yoshinori K. Okuji" writes: Hi, > On Thursday 25 January 2007 12:25, Lubomir Kundrak wrote: >> I've noticed, that GRUB 2 uses argp in grub-emu [1], whereas other >> utilities use getopt_long [2]. Wouldn't it be nice to make this >> consistent? > > Maybe. > >> I find the "GNU way," argp, approach more elegant, as demonstrated by a >> patch to util/i386/pc/grub-mkimage.c. Seeing a patch with more minuses >> than pluses is a good sign, indeed. >> >> The main argument against agrp framework could be, that non-GNU C >> libraries do not contain with it. There's a standalone libargp package >> [3] that is available for package systems of all major operating >> systems, including NetBSD and FreeBSD, so the only disadvantage is >> addding a dependency there. > > I preferred that libargp would be included in our source tree so that it would > be used when argp is not found in a system, but I guess Marco hasn't done it > yet. This depends on which is more convenient for users, using an external > shared library, or using our own. In GRUB Legacy, I included getopt for *BSD, > and I got positive answers. So I feel that it would be better to include. There is the library you mentioned and the argp implementation from gnulib. I personally prefer gnulib, because we don't have to worry about copyright at all in this case. But I agree, including it so things work on BSD is prefered. I assume you noticed grub-emu isn't compiled by default. It makes the situation a bit easier when using BSD. Although for a good port we need some argp implementation on BSD. -- Marco