From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1G6Dwt-0003IX-2c for mharc-grub-devel@gnu.org; Thu, 27 Jul 2006 18:03:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G6Dwr-0003IN-5n for grub-devel@gnu.org; Thu, 27 Jul 2006 18:03:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G6Dwp-0003IB-U9 for grub-devel@gnu.org; Thu, 27 Jul 2006 18:03:16 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G6Dwp-0003I8-Mq for grub-devel@gnu.org; Thu, 27 Jul 2006 18:03:15 -0400 Received: from [195.54.107.70] (helo=mxfep01.bredband.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G6Dyg-0006WB-37 for grub-devel@gnu.org; Thu, 27 Jul 2006 18:05:10 -0400 Received: from localhost.localdomain ([213.113.223.229] [213.113.223.229]) by mxfep01.bredband.com with ESMTP id <20060727220314.QJNG14783.mxfep01.bredband.com@localhost.localdomain> for ; Fri, 28 Jul 2006 00:03:14 +0200 From: Johan Rydberg To: grub-devel@gnu.org Date: Fri, 28 Jul 2006 00:15:40 +0200 Message-ID: <8764hilmnn.fsf@night.trouble.net> User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Subject: [PATCH] Do not require console control protocol. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2006 22:03:17 -0000 --=-=-= Hi, I would like to have the following patch committed. Some EFI implementations do not provide a console control protocol instance, and it is covered by neither EFI or UEFI specifications. ~j 2006-07-28 Johan Rydberg * kern/efi/efi.c (grub_efi_set_text_mode): Assume console already is in text mode if there is no console control protocol instance available. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=grub.efi-console-control.1.patch Index: kern/efi/efi.c =================================================================== RCS file: /sources/grub/grub2/kern/efi/efi.c,v retrieving revision 1.7 diff -u -r1.7 efi.c --- kern/efi/efi.c 27 May 2006 21:09:25 -0000 1.7 +++ kern/efi/efi.c 27 Jul 2006 22:01:49 -0000 @@ -125,7 +125,9 @@ c = grub_efi_locate_protocol (&console_control_guid, 0); if (! c) - return 0; + /* No console control protocol instance available, assume it is + already in text mode. */ + return 1; if (c->get_mode (c, &mode, 0, 0) != GRUB_EFI_SUCCESS) return 0; --=-=-=--