From: Ben Pfaff <blp@cs.stanford.edu>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Limit VIA and SIS AGP choices to x86
Date: Wed, 05 Jul 2006 11:24:22 -0700 [thread overview]
Message-ID: <8764ib29m1.fsf@benpfaff.org> (raw)
In-Reply-To: 20060705111057.a03fbcec.akpm@osdl.org
Andrew Morton <akpm@osdl.org> writes:
> On Wed, 5 Jul 2006 11:57:25 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
>> chipsets available.
>>
>> ...
>>
>> config AGP_SIS
>> tristate "SiS chipset support"
>> - depends on AGP
>> + depends on AGP && X86
>
> I never know what to do here.
>
> Sure, the driver will not be used on that architecture. But there is some
> benefit in being able to cross-compile that driver on other architectures
> anyway. Sometimes it will pick up missed #includes, sometimes printk
> mismatches, various other assumptions which might be OK for x86 right now
> but which might cause problems in the future.
Should we have a NONNATIVE config option analogous to
EXPERIMENTAL, so that it could be expressed as
depends on AGP && (X86 || NONNATIVE)
Seems to express the actual intentions.
--
Ben Pfaff
email: blp@cs.stanford.edu
web: http://benpfaff.org
next prev parent reply other threads:[~2006-07-05 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 17:57 [PATCH] Limit VIA and SIS AGP choices to x86 Matthew Wilcox
2006-07-05 18:10 ` Andrew Morton
2006-07-05 18:24 ` Ben Pfaff [this message]
2006-07-05 19:24 ` Dave Jones
2006-07-05 19:21 ` Dave Jones
2006-07-05 19:27 ` Arjan van de Ven
2006-07-05 19:36 ` Dave Jones
2006-07-05 21:39 ` H. Peter Anvin
2006-07-07 7:31 ` Indrek Kruusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8764ib29m1.fsf@benpfaff.org \
--to=blp@cs.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.