From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CUkFg-0001c8-1a for mharc-grub-devel@gnu.org; Thu, 18 Nov 2004 06:15:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUkFa-0001be-MF for grub-devel@gnu.org; Thu, 18 Nov 2004 06:14:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUkFW-0001Zj-Jg for grub-devel@gnu.org; Thu, 18 Nov 2004 06:14:51 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUkFW-0001Z7-6H for grub-devel@gnu.org; Thu, 18 Nov 2004 06:14:50 -0500 Received: from [145.74.66.11] (helo=mail-cn.han.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUk6P-0002rs-Mt for grub-devel@gnu.org; Thu, 18 Nov 2004 06:05:26 -0500 Received: from localhost (charlie.han.nl [145.74.66.9]) by mail-cn.han.nl (Postfix) with ESMTP id 2959BAE60 for ; Thu, 18 Nov 2004 11:46:14 +0100 (CET) Received: from mail-cn.han.nl ([145.74.66.11]) by localhost (charlie.han.nl [145.74.66.9]) (amavisd-new, port 10024) with ESMTP id 29380-02 for ; Thu, 18 Nov 2004 11:46:10 +0100 (CET) Received: from mail1.han.nl (mail1.han.nl [145.74.103.11]) by mail-cn.han.nl (Postfix) with ESMTP id BB529AF0E for ; Thu, 18 Nov 2004 11:46:09 +0100 (CET) Received: from marco.marco-g.com (mgerards.xs4all.nl [82.92.27.129]) by mail1.han.nl (Postfix) with ESMTP id 7B312C046 for ; Thu, 18 Nov 2004 11:46:09 +0100 (CET) Mail-Copies-To: metgerards@student.han.nl To: The development of GRUB 2 References: <87actg8ehq.fsf@marco.marco-g.com> <200411181032.10290.okuji@enbug.org> From: Marco Gerards Date: Thu, 18 Nov 2004 10:46:17 +0000 In-Reply-To: <200411181032.10290.okuji@enbug.org> (Yoshinori K. Okuji's message of "Thu, 18 Nov 2004 10:32:10 +0100") Message-ID: <8765434epy.fsf@marco.marco-g.com> User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by amavisd-new@vscan-cn.han.nl Subject: Re: Partition modules X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2004 11:14:55 -0000 "Yoshinori K. Okuji" writes: > On Thursday 18 November 2004 04:50, Hollis Blanchard wrote: >> I do have an objection here: members like "bsd_type" don't belong in >> a generic struct, but rather in grub_partition_bsd_type. I believe >> grub_partition should be the abstraction, i.e. what defines a >> partition in the general sense. start, len, and index are obviously >> good; offset is compensating for a DOS issue, though at least it has >> (irrelevant) meaning for an Apple map... but ext_offset and these >> dos_ and bsd_ things don't belong here IMHO. > > I agree with you in theory... but I guess it is a bit difficult to make > BSD disklabel independent, because it is sometimes used alone and it is > sometimes nested in other partition types. I hope Marco will find out a > good solution here. It should not be too hard. The extra members are only used in specific parts of the code, mainly in the i386/pc directories. Perhaps I could add a member which points to a user defined data structure. In that datastructure the extra information can be stored. The BSD disklabel is a weird special case. Perhaps we need some kind of nested partitions or so. I don't know if that will make sense because I have no knowledge about BSD slices and how they are used. Thanks, Marco