From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D7EC2D0A3 for ; Mon, 9 Nov 2020 09:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94F442084C for ; Mon, 9 Nov 2020 09:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="h92gxcIK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgKIJgl (ORCPT ); Mon, 9 Nov 2020 04:36:41 -0500 Received: from z5.mailgun.us ([104.130.96.5]:52907 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgKIJgl (ORCPT ); Mon, 9 Nov 2020 04:36:41 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604914600; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=NUG+xe2aYnHYm1NJnJvLO3G8nDtGuTSPGCrIjMUoJg4=; b=h92gxcIKZpvk04cPZECsxiRolv45l/5trU/z4kXnpqJN7TshMn9fTeGRItkP1CxCHdIqB+c8 GyyAp7zAEbbV5DKAmpb1CD0R8V8NntngtV1AKPg86E+b+m1XaQTfySriVxMdWuRJywUOs0j/ /zx5GR4Wr4CWcdemXbMihlOoUcA= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI5OTczNyIsICJwaG9uZS1kZXZlbEB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 5fa90da4dd52edb7344d1385 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 09 Nov 2020 09:36:36 GMT Sender: saiprakash.ranjan=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 693EBC433FF; Mon, 9 Nov 2020 09:36:36 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2CE19C433C6; Mon, 9 Nov 2020 09:36:35 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 Nov 2020 15:06:35 +0530 From: Sai Prakash Ranjan To: Marc Zyngier , Konrad Dybcio Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, Catalin Marinas , Will Deacon , Stephen Boyd , Rob Herring , Suzuki K Poulose , Steven Price , Mark Brown , Andrew Scull , Anshuman Khandual , Amit Daniel Kachhap , Ionela Voinescu , Kristina Martsenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: cpu_errata: Apply Erratum 845719 to KRYO2XX Silver In-Reply-To: <3faa81d537320dfb20bb3f882cfaea1b@kernel.org> References: <20201104232218.198800-1-konrad.dybcio@somainline.org> <20201104232218.198800-5-konrad.dybcio@somainline.org> <3faa81d537320dfb20bb3f882cfaea1b@kernel.org> Message-ID: <8771f66911522ab87fe1b9b16e4e9921@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org Hi Marc, On 2020-11-05 14:59, Marc Zyngier wrote: > On 2020-11-04 23:22, Konrad Dybcio wrote: >> QCOM KRYO2XX Silver cores are Cortex-A53 based and are >> susceptible to the 845719 erratum. Add them to the lookup >> list to apply the erratum. >> >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/kernel/cpu_errata.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/kernel/cpu_errata.c >> b/arch/arm64/kernel/cpu_errata.c >> index 61314fd70f13..cafaf0da05b7 100644 >> --- a/arch/arm64/kernel/cpu_errata.c >> +++ b/arch/arm64/kernel/cpu_errata.c >> @@ -299,6 +299,8 @@ static const struct midr_range >> erratum_845719_list[] = { >> MIDR_REV_RANGE(MIDR_CORTEX_A53, 0, 0, 4), >> /* Brahma-B53 r0p[0] */ >> MIDR_REV(MIDR_BRAHMA_B53, 0, 0), >> + /* Kryo2XX Silver rAp4 */ >> + MIDR_REV(MIDR_QCOM_KRYO_2XX_SILVER, 0xa, 0x4), > > Is this the only affected version? If this is actually an A53, how do > the > revisions map between Kryo and Cortex cores? > From what I see from the docs, this is the only version used in MSM8998(silver cores are based on Cortex A53) and it maps to r0p4. @Konrad, can you include (rap4 => r0p4) in comment. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765DEC2D0A3 for ; Mon, 9 Nov 2020 09:37:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5DD920789 for ; Mon, 9 Nov 2020 09:37:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yn7cX6gX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="bOS8k/6g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5DD920789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f8/MCD2YnFOnCO/fd4GlJV83zWqAF+0tchdVzaqynHo=; b=Yn7cX6gXsWYLeSDEJWPgyYi8V rycRboXxkiD9Xuo7mkph89OCyIizdW9MCS6XHUv41ZBn7eggcxMy+YWjsub6AFtpJvQmoH5WGb01V G6EmA3JG8zqhMMNV+Z1Bc1UxrzeDhLO44zlQeLVWpso0NxKUjhlkYit/DlQyryIUludFaXhMzzE5u TRZxwtCFrjUT4jonUDHACQas5OFtKWQCCO0hbxcOFONhjSPc8gAEYtdRa0yZxPu44GdhYywlBkgb8 bj9VcaWNzpxrMN4t78N0jRfXy5PzgLqvVj+jc9LvtDI9O6nszVoVIUbQmx96fxIRPA6N+DhLCY6Ic vk9JjeoEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc3bc-0006fe-RH; Mon, 09 Nov 2020 09:36:57 +0000 Received: from z5.mailgun.us ([104.130.96.5]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc3bZ-0006f3-2I for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 09:36:55 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604914614; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=NUG+xe2aYnHYm1NJnJvLO3G8nDtGuTSPGCrIjMUoJg4=; b=bOS8k/6g27Nnd7Csp5bHJtrjs7FgF9gDA1YbZVlwFAQvvowS7fmJMZwUEws9FGZhUYP1COlA R+GQSDt1qTCXT6tOBLvZy0vgwnQkacz2GnxXX7G+YP2UjdbdeKJv0XckTMZ1gYKYnYFdHmEf gvUGOIDxLjjLIVTnogzrJ45YSDg= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 5fa90da49d6b206d94c9c340 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 09 Nov 2020 09:36:36 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 62D0CC433F0; Mon, 9 Nov 2020 09:36:36 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2CE19C433C6; Mon, 9 Nov 2020 09:36:35 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 09 Nov 2020 15:06:35 +0530 From: Sai Prakash Ranjan To: Marc Zyngier , Konrad Dybcio Subject: Re: [PATCH 4/4] arm64: cpu_errata: Apply Erratum 845719 to KRYO2XX Silver In-Reply-To: <3faa81d537320dfb20bb3f882cfaea1b@kernel.org> References: <20201104232218.198800-1-konrad.dybcio@somainline.org> <20201104232218.198800-5-konrad.dybcio@somainline.org> <3faa81d537320dfb20bb3f882cfaea1b@kernel.org> Message-ID: <8771f66911522ab87fe1b9b16e4e9921@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_043654_464524_31CAB4BA X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Ionela Voinescu , Suzuki K Poulose , Catalin Marinas , Anshuman Khandual , linux-kernel@vger.kernel.org, Kristina Martsenko , Stephen Boyd , Mark Brown , martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, angelogioacchino.delregno@somainline.org, Amit Daniel Kachhap , marijn.suijten@somainline.org, phone-devel@vger.kernel.org, Will Deacon , Steven Price , linux-arm-kernel@lists.infradead.org, Andrew Scull Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 2020-11-05 14:59, Marc Zyngier wrote: > On 2020-11-04 23:22, Konrad Dybcio wrote: >> QCOM KRYO2XX Silver cores are Cortex-A53 based and are >> susceptible to the 845719 erratum. Add them to the lookup >> list to apply the erratum. >> >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/kernel/cpu_errata.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm64/kernel/cpu_errata.c >> b/arch/arm64/kernel/cpu_errata.c >> index 61314fd70f13..cafaf0da05b7 100644 >> --- a/arch/arm64/kernel/cpu_errata.c >> +++ b/arch/arm64/kernel/cpu_errata.c >> @@ -299,6 +299,8 @@ static const struct midr_range >> erratum_845719_list[] = { >> MIDR_REV_RANGE(MIDR_CORTEX_A53, 0, 0, 4), >> /* Brahma-B53 r0p[0] */ >> MIDR_REV(MIDR_BRAHMA_B53, 0, 0), >> + /* Kryo2XX Silver rAp4 */ >> + MIDR_REV(MIDR_QCOM_KRYO_2XX_SILVER, 0xa, 0x4), > > Is this the only affected version? If this is actually an A53, how do > the > revisions map between Kryo and Cortex cores? > From what I see from the docs, this is the only version used in MSM8998(silver cores are based on Cortex A53) and it maps to r0p4. @Konrad, can you include (rap4 => r0p4) in comment. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel