From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@fb.com>, io-uring@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fs: don't randomized kiocb fields
Date: Fri, 12 Aug 2022 17:00:18 -0600 [thread overview]
Message-ID: <8773ef66-e6a4-ed64-71ed-837cac5341f5@kernel.dk> (raw)
In-Reply-To: <20220812225633.3287847-1-kbusch@fb.com>
On 8/12/22 4:56 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> This is a size sensitive structure and randomizing can introduce extra
> padding that breaks io_uring's fixed size expectations. There are few
> fields here as it is, half of which need a fixed order to optimally
> pack, so the randomization isn't providing much.
I'll add the link to the previous discussion as well in the commit:
Link: https://lore.kernel.org/io-uring/b6f508ca-b1b2-5f40-7998-e4cff1cf7212@kernel.dk/
as it's pretty useful for context.
--
Jens Axboe
next prev parent reply other threads:[~2022-08-12 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 22:56 [PATCH] fs: don't randomized kiocb fields Keith Busch
2022-08-12 23:00 ` Jens Axboe [this message]
2022-08-13 7:59 ` Christoph Hellwig
2022-08-13 14:33 ` Jens Axboe
2022-08-14 10:35 ` Matthew Wilcox
2022-08-15 14:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8773ef66-e6a4-ed64-71ed-837cac5341f5@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.