All of lore.kernel.org
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: git@vger.kernel.org
Cc: Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [BUG REPORT] t5322: demonstrate a pack-objects bug
Date: Wed, 28 Nov 2018 14:55:55 -0500	[thread overview]
Message-ID: <8774b686-e399-975f-b033-421b3ec1427d@gmail.com> (raw)
In-Reply-To: <20181128194536.57019-1-dstolee@microsoft.com>

On 11/28/2018 2:45 PM, Derrick Stolee wrote:
> I was preparing a new "sparse" algorithm for calculating the
> interesting objects to send on push. The important steps happen
> during 'git pack-objects', so I was creating test cases to see
> how the behavior changes in narrow cases. Specifically, when
> copying a directory across sibling directories (see test case),
> the new logic would accidentally send that object as an extra.
>
> However, I found a bug in the existing logic. The included test
> demonstrates this during the final 'git index-pack' call. It
> fails with the message
>
> 	'fatal: pack has 1 unresolved delta'

I realize now that I've gone through this effort that the problem is me 
(of course it is).

> +	git pack-objects --stdout --thin --revs <packinput.txt >nonsparse.pack &&

Since I'm packing thin packs, the index operation is complaining about 
deltas. So, I need to use a different mechanism to list the objects in 
the pack (say, 'git verify-pack -v').

Sorry for the noise!

Thanks,

-Stolee


      reply	other threads:[~2018-11-28 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 19:45 [BUG REPORT] t5322: demonstrate a pack-objects bug Derrick Stolee
2018-11-28 19:55 ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8774b686-e399-975f-b033-421b3ec1427d@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.